Skip to content

Commit c08f84e

Browse files
committed
NullableVsInlineThenTest: minor tweaks
* Let the two tests use different asyn visibility tokens. * Fix up the test names - the "Only" at the end of the `testNullableReadonlyOnly` was about the fact that that test didn't have visibility declared, which is not applicable for the new tests.
1 parent 78d1645 commit c08f84e

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

tests/Core/Tokenizers/PHP/NullableVsInlineThenTest.inc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ class Nullable
55
/* testNullableReadonlyOnly */
66
readonly ?int $prop;
77

8-
/* testNullablePrivateSetOnly */
8+
/* testNullablePrivateSet */
99
private(set) ?int $prop2;
1010

11-
/* testNullablePublicPrivateSetOnly */
12-
public private(set) ?int $prop3;
11+
/* testNullablePublicProtectedSet */
12+
public protected(set) ?int $prop3;
1313
}
1414

1515
class InlineThen

tests/Core/Tokenizers/PHP/NullableVsInlineThenTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ public function testNullable($testMarker)
5050
public static function dataNullable()
5151
{
5252
return [
53-
'property declaration, readonly, no visibility' => ['/* testNullableReadonlyOnly */'],
54-
'property declaration, private set' => ['/* testNullablePrivateSetOnly */'],
55-
'property declaration, public and private set' => ['/* testNullablePublicPrivateSetOnly */'],
53+
'property declaration, readonly, no visibility' => ['/* testNullableReadonlyOnly */'],
54+
'property declaration, private set' => ['/* testNullablePrivateSet */'],
55+
'property declaration, public and protected set' => ['/* testNullablePublicProtectedSet */'],
5656
];
5757

5858
}//end dataNullable()

0 commit comments

Comments
 (0)