Fixed test in ComparisonOperatorUsageSniff and added tests for it.

Author: rhorber

CodeSniffer/Standards/Squiz/Sniffs/Operators/ComparisonOperatorUsageSniff.php

@@ -154,7 +154,7 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
 
                 $start = $phpcsFile->findNext(PHP_CodeSniffer_Tokens::$emptyTokens, ($i + 1), null, true);
             } else {
-                if (isset($tokens[$stackPtr]['parenthesis_opener']) === false) {
+                if (isset($tokens[$end]['parenthesis_opener']) === false) {
                     return;
                 }
 

CodeSniffer/Standards/Squiz/Tests/Operators/ComparisonOperatorUsageUnitTest.inc

@@ -117,3 +117,15 @@ while (TRUE) {
 
 while (FALSE) {
 }
+
+$var = ($var1 === true) ? $var1 : "foobar";
+
+$var = ($var1 == true) ? $var1 : "foobar";
+
+$var = ($var1 === false) ? $var1 : "foobar";
+
+$var = ($var1 == false) ? $var1 : "foobar";
+
+$var = ($var1 === 0) ? $var1 : "foobar";
+
+$var = ($var1 == 0) ? $var1 : "foobar";

CodeSniffer/Standards/Squiz/Tests/Operators/ComparisonOperatorUsageUnitTest.js

@@ -57,3 +57,15 @@ for (one = 10; one !== 0; one--) {
 
 for (type in types) {
 }
+
+variable = (variable2 === true) ? variable1 : "foobar";
+
+variable = (variable2 == true) ? variable1 : "foobar";
+
+variable = (variable2 === false) ? variable1 : "foobar";
+
+variable = (variable2 == false) ? variable1 : "foobar";
+
+variable = (variable2 === 0) ? variable1 : "foobar";
+
+variable = (variable2 == 0) ? variable1 : "foobar";

CodeSniffer/Standards/Squiz/Tests/Operators/ComparisonOperatorUsageUnitTest.php

@@ -71,6 +71,9 @@ public function getErrorList($testFile='ComparisonOperatorUsageUnitTest.inc')
                     100 => 1,
                     106 => 1,
                     112 => 1,
+                    123 => 1,
+                    127 => 1,
+                    131 => 1,
                    );
             break;
         case 'ComparisonOperatorUsageUnitTest.js':
@@ -83,6 +86,9 @@ public function getErrorList($testFile='ComparisonOperatorUsageUnitTest.inc')
                     40 => 1,
                     47 => 1,
                     52 => 1,
+                    63 => 1,
+                    67 => 1,
+                    71 => 1,
                    );
             break;
         default: