4.0 | Filters: add parameter types

Author: jrfnl

src/Filters/Filter.php

@@ -15,6 +15,7 @@
 use PHP_CodeSniffer\Util\Common;
 use RecursiveDirectoryIterator;
 use RecursiveFilterIterator;
+use RecursiveIterator;
 use ReturnTypeWillChange;
 
 class Filter extends RecursiveFilterIterator
@@ -84,7 +85,7 @@ class Filter extends RecursiveFilterIterator
      *
      * @return void
      */
-    public function __construct($iterator, $basedir, Config $config, Ruleset $ruleset)
+    public function __construct(RecursiveIterator $iterator, string $basedir, Config $config, Ruleset $ruleset)
     {
         parent::__construct($iterator);
         $this->basedir = $basedir;
@@ -177,7 +178,7 @@ public function getChildren()
      *
      * @return bool
      */
-    protected function shouldProcessFile($path)
+    protected function shouldProcessFile(string $path)
     {
         // Check that the file's extension is one we are checking.
         // We are strict about checking the extension and we don't
@@ -224,7 +225,7 @@ protected function shouldProcessFile($path)
      *
      * @return bool
      */
-    protected function shouldIgnorePath($path)
+    protected function shouldIgnorePath(string $path)
     {
         if ($this->ignoreFilePatterns === null) {
             $this->ignoreDirPatterns  = [];

src/Filters/GitModified.php

@@ -76,7 +76,7 @@ protected function getAllowedFiles()
      *
      * @return array
      */
-    protected function exec($cmd)
+    protected function exec(string $cmd)
     {
         $output   = [];
         $lastLine = exec($cmd, $output);

src/Filters/GitStaged.php

@@ -78,7 +78,7 @@ protected function getAllowedFiles()
      *
      * @return array
      */
-    protected function exec($cmd)
+    protected function exec(string $cmd)
     {
         $output   = [];
         $lastLine = exec($cmd, $output);