Skip to content

Commit d11e893

Browse files
committed
Combine the two existing abstract classes into one
1 parent 4bfe019 commit d11e893

File tree

2 files changed

+13
-15
lines changed

2 files changed

+13
-15
lines changed

src/Standards/Generic/Tests/CodeAnalysis/UselessOverridingMethodUnitTest.1.inc

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,15 @@ class Bar {
8989

9090
abstract class AbstractFoo {
9191
abstract public function sniffShouldBailEarly();
92+
93+
public function uselessMethodInAbstractClass() {
94+
parent::uselessMethodInAbstractClass();
95+
}
96+
97+
public function usefulMethodInAbstractClass() {
98+
$a = 1;
99+
parent::usefulMethodInAbstractClass($a);
100+
}
92101
}
93102

94103
interface InterfaceFoo {
@@ -109,17 +118,6 @@ trait TraitFoo {
109118
}
110119
}
111120

112-
abstract class AbstractBar extends AbstractFoo {
113-
public function uselessMethodInAbstractClass() {
114-
parent::uselessMethodInAbstractClass();
115-
}
116-
117-
public function usefulMethodInAbstractClass() {
118-
$a = 1;
119-
parent::usefulMethodInAbstractClass($a);
120-
}
121-
}
122-
123121
enum EnumFoo {
124122
public function sniffShouldBailEarly() {
125123
// Invalid code needed to ensure an error is NOT triggered and the sniff bails early when handling an enum method.

src/Standards/Generic/Tests/CodeAnalysis/UselessOverridingMethodUnitTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@ public function getWarningList($testFile='')
5656
56 => 1,
5757
68 => 1,
5858
72 => 1,
59-
107 => 1,
60-
113 => 1,
61-
136 => 1,
62-
148 => 1,
59+
93 => 1,
60+
116 => 1,
61+
134 => 1,
62+
146 => 1,
6363
];
6464
default:
6565
return [];

0 commit comments

Comments
 (0)