Tests: always use type strict assertions

Author: jrfnl

tests/Core/Autoloader/DetermineLoadedClassTest.php

@@ -58,7 +58,7 @@ public function testOrdered()
         ];
 
         $className = Autoload::determineLoadedClass($classesBeforeLoad, $classesAfterLoad);
-        $this->assertEquals('PHP_CodeSniffer\Tests\Core\Autoloader\Sub\C', $className);
+        $this->assertSame('PHP_CodeSniffer\Tests\Core\Autoloader\Sub\C', $className);
 
     }//end testOrdered()
 
@@ -88,7 +88,7 @@ public function testUnordered()
         ];
 
         $className = Autoload::determineLoadedClass($classesBeforeLoad, $classesAfterLoad);
-        $this->assertEquals('PHP_CodeSniffer\Tests\Core\Autoloader\Sub\C', $className);
+        $this->assertSame('PHP_CodeSniffer\Tests\Core\Autoloader\Sub\C', $className);
 
         $classesAfterLoad = [
             'classes'    => [
@@ -102,7 +102,7 @@ public function testUnordered()
         ];
 
         $className = Autoload::determineLoadedClass($classesBeforeLoad, $classesAfterLoad);
-        $this->assertEquals('PHP_CodeSniffer\Tests\Core\Autoloader\Sub\C', $className);
+        $this->assertSame('PHP_CodeSniffer\Tests\Core\Autoloader\Sub\C', $className);
 
         $classesAfterLoad = [
             'classes'    => [
@@ -116,7 +116,7 @@ public function testUnordered()
         ];
 
         $className = Autoload::determineLoadedClass($classesBeforeLoad, $classesAfterLoad);
-        $this->assertEquals('PHP_CodeSniffer\Tests\Core\Autoloader\Sub\C', $className);
+        $this->assertSame('PHP_CodeSniffer\Tests\Core\Autoloader\Sub\C', $className);
 
     }//end testUnordered()
 

tests/Core/Filters/Filter/AcceptTest.php

@@ -54,7 +54,7 @@ public function testExcludePatterns($inputPaths, $expectedOutput)
         $fakeDI = new RecursiveArrayIterator($inputPaths);
         $filter = new Filter($fakeDI, '/', self::$config, self::$ruleset);
 
-        $this->assertEquals($expectedOutput, $this->getFilteredResultsAsArray($filter));
+        $this->assertSame($expectedOutput, $this->getFilteredResultsAsArray($filter));
 
     }//end testExcludePatterns()
 

tests/Core/Filters/GitModifiedTest.php

@@ -45,7 +45,7 @@ public function testFileNamePassesAsBasePathWillTranslateToDirname()
             ->method('exec')
             ->willReturn(['autoload.php']);
 
-        $this->assertEquals([$rootFile], $this->getFilteredResultsAsArray($mockObj));
+        $this->assertSame([$rootFile], $this->getFilteredResultsAsArray($mockObj));
 
     }//end testFileNamePassesAsBasePathWillTranslateToDirname()
 
@@ -76,7 +76,7 @@ public function testAcceptOnlyGitModified($inputPaths, $outputGitModified, $expe
             ->method('exec')
             ->willReturn($outputGitModified);
 
-        $this->assertEquals($expectedOutput, $this->getFilteredResultsAsArray($mockObj));
+        $this->assertSame($expectedOutput, $this->getFilteredResultsAsArray($mockObj));
 
     }//end testAcceptOnlyGitModified()
 

tests/Core/Filters/GitStagedTest.php

@@ -45,7 +45,7 @@ public function testFileNamePassesAsBasePathWillTranslateToDirname()
             ->method('exec')
             ->willReturn(['autoload.php']);
 
-        $this->assertEquals([$rootFile], $this->getFilteredResultsAsArray($mockObj));
+        $this->assertSame([$rootFile], $this->getFilteredResultsAsArray($mockObj));
 
     }//end testFileNamePassesAsBasePathWillTranslateToDirname()
 
@@ -76,7 +76,7 @@ public function testAcceptOnlyGitStaged($inputPaths, $outputGitStaged, $expected
             ->method('exec')
             ->willReturn($outputGitStaged);
 
-        $this->assertEquals($expectedOutput, $this->getFilteredResultsAsArray($mockObj));
+        $this->assertSame($expectedOutput, $this->getFilteredResultsAsArray($mockObj));
 
     }//end testAcceptOnlyGitStaged()
 

tests/Core/Ruleset/RegisterSniffsTest.php

@@ -229,7 +229,7 @@ public function testRegisteredSniffsBothRestrictionsAndExclusions()
 
         self::$ruleset->registerSniffs(self::$psr1SniffAbsolutePaths, $restrictions, $exclusions);
 
-        $this->assertEquals($expected, array_keys(self::$ruleset->sniffs));
+        $this->assertSame($expected, array_keys(self::$ruleset->sniffs));
 
     }//end testRegisteredSniffsBothRestrictionsAndExclusions()
 

tests/Core/Tokenizers/PHP/NamedFunctionCallArgumentsTest.php

@@ -746,7 +746,7 @@ public function testOtherColonsInTernary($testMarker)
         // Third colon should be T_COLON for the return type.
         $colonCount = 0;
         for ($i = ($startOfStatement + 1); $tokens[$i]['line'] === $tokens[$startOfStatement]['line']; $i++) {
-            $this->assertNotEquals(T_PARAM_NAME, $tokens[$i]['code'], "Token $i is tokenized as parameter label");
+            $this->assertNotSame(T_PARAM_NAME, $tokens[$i]['code'], "Token $i is tokenized as parameter label");
 
             if ($tokens[$i]['content'] === ':') {
                 ++$colonCount;