Merge pull request #37 from PHPCSStandards/phpcs-4.x/3115-let-static-be-static

4.0 | Let `T_STATIC` be `T_STATIC`

Author: jrfnl

src/Standards/Squiz/Sniffs/WhiteSpace/ScopeKeywordSpacingSniff.php

@@ -56,6 +56,7 @@ public function process(File $phpcsFile, $stackPtr)
         if ($tokens[$stackPtr]['code'] === T_STATIC) {
             if (($nextToken === false || $tokens[$nextToken]['code'] === T_DOUBLE_COLON)
                 || $tokens[$prevToken]['code'] === T_NEW
+                || $tokens[$prevToken]['code'] === T_INSTANCEOF
             ) {
                 // Late static binding, e.g., static:: OR new static() usage or live coding.
                 return;

src/Standards/Squiz/Tests/WhiteSpace/OperatorSpacingUnitTest.1.inc

@@ -262,7 +262,7 @@ if ($line{-1} === ':') {
 }
 
 $a = $a instanceof $b;
-$a = $a  instanceof  $b;
+$a = $a  instanceof  static;
 $a = ($a)instanceof$b;
 
 fn&($x) => $x;

src/Standards/Squiz/Tests/WhiteSpace/OperatorSpacingUnitTest.1.inc.fixed

@@ -256,7 +256,7 @@ if ($line{-1} === ':') {
 }
 
 $a = $a instanceof $b;
-$a = $a instanceof $b;
+$a = $a instanceof static;
 $a = ($a) instanceof $b;
 
 fn&($x) => $x;

src/Tokenizers/PHP.php

@@ -3348,24 +3348,6 @@ protected function processAdditional()
                     }
                 }
 
-                continue;
-            } else if ($this->tokens[$i]['code'] === T_STATIC) {
-                for ($x = ($i - 1); $x > 0; $x--) {
-                    if (isset(Tokens::$emptyTokens[$this->tokens[$x]['code']]) === false) {
-                        break;
-                    }
-                }
-
-                if ($this->tokens[$x]['code'] === T_INSTANCEOF) {
-                    $this->tokens[$i]['code'] = T_STRING;
-                    $this->tokens[$i]['type'] = 'T_STRING';
-
-                    if (PHP_CODESNIFFER_VERBOSITY > 1) {
-                        $line = $this->tokens[$i]['line'];
-                        StatusWriter::write("* token $i on line $line changed from T_STATIC to T_STRING", 1);
-                    }
-                }
-
                 continue;
             } else if ($this->tokens[$i]['code'] === T_TRUE
                 || $this->tokens[$i]['code'] === T_FALSE