Merge pull request #1189 from PHPCSStandards/php-8.4/various-sniffs-add-tests-for-abstract-properties

PHP 8.4 | Various sniffs: add tests with abstract properties

Author: jrfnl

src/Standards/Squiz/Tests/Classes/LowercaseClassKeywordsUnitTest.inc

@@ -18,3 +18,7 @@ $anon = new ReadOnly class() {};
 class FinalProperties {
     FINAL int $prop = 1;
 }
+
+ABSTRACT class AbstractProperties {
+    Abstract int $prop {set;}
+}

src/Standards/Squiz/Tests/Classes/LowercaseClassKeywordsUnitTest.inc.fixed

@@ -18,3 +18,7 @@ $anon = new readonly class() {};
 class FinalProperties {
     final int $prop = 1;
 }
+
+abstract class AbstractProperties {
+    abstract int $prop {set;}
+}

src/Standards/Squiz/Tests/Classes/LowercaseClassKeywordsUnitTest.php

@@ -42,6 +42,8 @@ public function getErrorList()
             14 => 1,
             16 => 1,
             19 => 1,
+            22 => 1,
+            23 => 1,
         ];
 
         return $errors;

src/Standards/Squiz/Tests/Commenting/BlockCommentUnitTest.inc

@@ -331,3 +331,10 @@ class AsymVisibility {
      */
     private(set) int $prop = 1;
 }
+
+abstract class AbstractProperties {
+    /**
+     * Comment should be ignored.
+     */
+    abstract int $prop {get;}
+}

src/Standards/Squiz/Tests/Commenting/BlockCommentUnitTest.inc.fixed

@@ -333,3 +333,10 @@ class AsymVisibility {
      */
     private(set) int $prop = 1;
 }
+
+abstract class AbstractProperties {
+    /**
+     * Comment should be ignored.
+     */
+    abstract int $prop {get;}
+}

src/Standards/Squiz/Tests/Commenting/DocCommentAlignmentUnitTest.inc

@@ -131,3 +131,16 @@ class AsymVisibility {
      */
     private(set) int $prop = 1;
 }
+
+/**
+  *  Some info about the class here.
+    */
+abstract class AbstractClassWithAbstractProp
+{
+    /**
+   *Some info about the property here.
+    *
+     *  @var int
+      */
+    abstract $property {get;}
+}

src/Standards/Squiz/Tests/Commenting/DocCommentAlignmentUnitTest.inc.fixed

@@ -131,3 +131,16 @@ class AsymVisibility {
      */
     private(set) int $prop = 1;
 }
+
+/**
+ *  Some info about the class here.
+ */
+abstract class AbstractClassWithAbstractProp
+{
+    /**
+     * Some info about the property here.
+     *
+     * @var int
+     */
+    abstract $property {get;}
+}

src/Standards/Squiz/Tests/Commenting/DocCommentAlignmentUnitTest.php

@@ -68,6 +68,13 @@ public function getErrorList($testFile='')
             $errors[121] = 1;
             $errors[125] = 1;
             $errors[126] = 1;
+
+            $errors[136] = 1;
+            $errors[137] = 1;
+            $errors[141] = 2;
+            $errors[142] = 1;
+            $errors[143] = 1;
+            $errors[144] = 1;
         }//end if
 
         return $errors;

src/Standards/Squiz/Tests/Scope/MemberVarScopeUnitTest.inc

@@ -85,3 +85,7 @@ class AsymVisibility {
     protected(set) public $asymPublicProtected  = 'hello';
     protected private(set) $asymProtectedPrivate  = 'hello';
 }
+
+abstract class PHP84AbstractProperties {
+    abstract string $abstract {get;}
+}

src/Standards/Squiz/Tests/Scope/MemberVarScopeUnitTest.php

@@ -43,6 +43,7 @@ public function getErrorList()
             80 => 1,
             81 => 1,
             82 => 1,
+            90 => 1,
         ];
 
     }//end getErrorList()