Skip to content

Commit dd00784

Browse files
committed
Apply suggestions from code review
Add readonly class tests and remove unnecessary tests
1 parent 3bffa86 commit dd00784

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/Standards/Generic/Tests/NamingConventions/AbstractClassNamePrefixUnitTest.1.inc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ abstract class abstractOkCaseOfPrefixIsNotEnforced
5656

5757
final class FinalClassShouldNotTriggerWarning {}
5858

59-
class ChildClassShouldNotTriggerWarning extends AbstractClassName {}
59+
readonly class ReadonlyClassShouldNotTriggerWarning {}
6060

61-
class ClassImplementingInterfaceShouldNotTriggerWarning implements InterfaceName {}
61+
abstract readonly class AbstractReadonlyClassWithPrefixShouldNotTriggerWarning {}
62+
63+
abstract readonly class ReadonlyAbstractClassShouldTriggerWarningWhenPrefixIsMissing {}

src/Standards/Generic/Tests/NamingConventions/AbstractClassNamePrefixUnitTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ public function getErrorList($testFile='')
3939
18 => 1,
4040
23 => 1,
4141
42 => 1,
42+
63 => 1,
4243
];
4344
default:
4445
return [];

0 commit comments

Comments
 (0)