Skip to content

Commit e3d3100

Browse files
committed
Replace default value of first parameter in getErrorList() with ''
Replacing the default value with an empty string. Per Juliette's comment (#163 (comment)) there are three reasons why we want to do that: - The default value has no value in practice. It is an optional argument which is not enforced via the abstract functions, but is passed in all cases, so the default is never used in practice. - Setting the default value as file 1 also has an assumption implied, while IMO assumptions have no place in a test suite. - Maintainability - one less thing to have to keep in sync and to guard against typos
1 parent 4231f69 commit e3d3100

34 files changed

+34
-34
lines changed

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class InlineControlStructureUnitTest extends AbstractSniffUnitTest
3030
*
3131
* @return array<int, int>
3232
*/
33-
public function getErrorList($testFile='InlineControlStructureUnitTest.1.inc')
33+
public function getErrorList($testFile='')
3434
{
3535
switch ($testFile) {
3636
case 'InlineControlStructureUnitTest.1.inc':

src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class LowerCaseConstantUnitTest extends AbstractSniffUnitTest
3030
*
3131
* @return array<int, int>
3232
*/
33-
public function getErrorList($testFile='LowerCaseConstantUnitTest.inc')
33+
public function getErrorList($testFile='')
3434
{
3535
switch ($testFile) {
3636
case 'LowerCaseConstantUnitTest.inc':

src/Standards/Generic/Tests/Strings/UnnecessaryStringConcatUnitTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class UnnecessaryStringConcatUnitTest extends AbstractSniffUnitTest
3030
*
3131
* @return array<int, int>
3232
*/
33-
public function getErrorList($testFile='UnnecessaryStringConcatUnitTest.inc')
33+
public function getErrorList($testFile='')
3434
{
3535
switch ($testFile) {
3636
case 'UnnecessaryStringConcatUnitTest.inc':

src/Standards/Generic/Tests/VersionControl/GitMergeConflictUnitTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class GitMergeConflictUnitTest extends AbstractSniffUnitTest
3030
*
3131
* @return array<int, int>
3232
*/
33-
public function getErrorList($testFile='GitMergeConflictUnitTest.1.inc')
33+
public function getErrorList($testFile='')
3434
{
3535
switch ($testFile) {
3636
case 'GitMergeConflictUnitTest.1.inc':

src/Standards/Generic/Tests/WhiteSpace/DisallowSpaceIndentUnitTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function setCliValues($testFile, $config)
4949
*
5050
* @return array<int, int>
5151
*/
52-
public function getErrorList($testFile='DisallowSpaceIndentUnitTest.1.inc')
52+
public function getErrorList($testFile='')
5353
{
5454
switch ($testFile) {
5555
case 'DisallowSpaceIndentUnitTest.1.inc':

src/Standards/Generic/Tests/WhiteSpace/IncrementDecrementSpacingUnitTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class IncrementDecrementSpacingUnitTest extends AbstractSniffUnitTest
3030
*
3131
* @return array<int, int>
3232
*/
33-
public function getErrorList($testFile='IncrementDecrementSpacingUnitTest.inc')
33+
public function getErrorList($testFile='')
3434
{
3535
$errors = [
3636
5 => 1,

src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public function setCliValues($testFile, $config)
5050
*
5151
* @return array<int, int>
5252
*/
53-
public function getErrorList($testFile='ScopeIndentUnitTest.inc')
53+
public function getErrorList($testFile='')
5454
{
5555
if ($testFile === 'ScopeIndentUnitTest.1.js') {
5656
return [

src/Standards/MySource/Tests/Debug/FirebugConsoleUnitTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class FirebugConsoleUnitTest extends AbstractSniffUnitTest
3030
*
3131
* @return array<int, int>
3232
*/
33-
public function getErrorList($testFile='FirebugConsoleUnitTest.js')
33+
public function getErrorList($testFile='')
3434
{
3535
if ($testFile !== 'FirebugConsoleUnitTest.js') {
3636
return [];

src/Standards/MySource/Tests/Objects/AssignThisUnitTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class AssignThisUnitTest extends AbstractSniffUnitTest
3030
*
3131
* @return array<int, int>
3232
*/
33-
public function getErrorList($testFile='AssignThisUnitTest.js')
33+
public function getErrorList($testFile='')
3434
{
3535
if ($testFile !== 'AssignThisUnitTest.js') {
3636
return [];

src/Standards/MySource/Tests/Strings/JoinStringsUnitTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class JoinStringsUnitTest extends AbstractSniffUnitTest
3030
*
3131
* @return array<int, int>
3232
*/
33-
public function getErrorList($testFile='JoinStringsUnitTest.js')
33+
public function getErrorList($testFile='')
3434
{
3535
if ($testFile !== 'JoinStringsUnitTest.js') {
3636
return [];

0 commit comments

Comments
 (0)