Skip to content

Commit e6146ae

Browse files
committed
ProcessRulesetBrokenRulesetTest: more tweaks for different libxml output
Looks like there are some more libxml quirks to take into account with different message content on different OSes. This updates the tests to allow for them to pass on PHP < 8.0 with libxml 2.9.x on Windows. Also adds the `@group Windows` annotation to ensure these tests are also run on Windows in CI.
1 parent 9981876 commit e6146ae

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

tests/Core/Ruleset/ProcessRulesetBrokenRulesetTest.php

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@
2121
* (duplicate error messages).
2222
*
2323
* @runTestsInSeparateProcesses
24-
* @preserveGlobalState disabled
24+
* @preserveGlobalState disabled
25+
*
26+
* @group Windows
2527
*
2628
* @covers \PHP_CodeSniffer\Ruleset::processRuleset
2729
*/
@@ -60,7 +62,7 @@ public function testBrokenRulesetSingleError()
6062
$config = new ConfigDouble(["--standard=$standard"]);
6163

6264
$regex = '`^ERROR: Ruleset \S+ProcessRulesetBrokenRulesetSingleErrorTest\.xml is not valid\R';
63-
$regex .= '- On line 3, column 1: Premature end of data in tag ruleset line 2\R$`';
65+
$regex .= '- On line 3, column 1: (Premature end of data in tag ruleset line 2|EndTag: \'</\' not found)\R$`';
6466

6567
$this->expectRuntimeExceptionRegex($regex);
6668

@@ -81,8 +83,8 @@ public function testBrokenRulesetMultiError()
8183

8284
$regex = '`^ERROR: Ruleset \S+ProcessRulesetBrokenRulesetMultiErrorTest\.xml is not valid\R';
8385
$regex .= '- On line 8, column 12: Opening and ending tag mismatch: property line 7 and rule\R';
84-
$regex .= '- On line 10, column 11: Opening and ending tag mismatch: properties line 5 and ruleset\R';
85-
$regex .= '(- On line 11, column 1: Premature end of data in tag rule line 4\R)?$`';
86+
$regex .= '- On line 10, column 11: Opening and ending tag mismatch: properties line (5|7) and ruleset\R';
87+
$regex .= '(- On line 11, column 1: (Premature end of data in tag rule line 4|EndTag: \'</\' not found)\R)?$`';
8688

8789
$this->expectRuntimeExceptionRegex($regex);
8890

0 commit comments

Comments
 (0)