Generic/UpperCaseConstantName: handle unconventional spacing and comments after define(

This commit fixes false negatives in the sniff when handling
unconventional spacing and comments after `define(`. When checking for
the constant name after the opening parenthesis, the sniff would
incorrectly exclude only whitespaces while comments can also be placed
between the opening parenthesis and the constant name.

Looking for the constant name by getting the next non-empty token after
the opening parenthesis fixes this problem.

The added tests also include comments between `define` and the opening
parenthesis but that was already handled correctly by the sniff.

Author: rodrigoprimo

src/Standards/Generic/Sniffs/NamingConventions/UpperCaseConstantNameSniff.php

@@ -103,8 +103,8 @@ public function process(File $phpcsFile, $stackPtr)
             return;
         }
 
-        // The next non-whitespace token must be the constant name.
-        $constPtr = $phpcsFile->findNext(T_WHITESPACE, ($openBracket + 1), null, true);
+        // The next non-empty token must be the constant name.
+        $constPtr = $phpcsFile->findNext(Tokens::$emptyTokens, ($openBracket + 1), null, true);
         if ($tokens[$constPtr]['code'] !== T_CONSTANT_ENCAPSED_STRING) {
             return;
         }

src/Standards/Generic/Tests/NamingConventions/UpperCaseConstantNameUnitTest.inc

@@ -41,3 +41,13 @@ class TypedConstants {
     const FALSE false = false; // Yes, false can be used as a constant name, don't ask.
     const array ARRAY = array(); // Same goes for array.
 }
+
+define /* comment */ ( /* comment */ 'CommentsInUnconventionalPlaces', 'value' );
+
+define
+// comment
+(
+    // phpcs:ignore Stnd.Cat.SniffName -- for reasons.
+    'CommentsInUnconventionalPlaces',
+    'value'
+);

src/Standards/Generic/Tests/NamingConventions/UpperCaseConstantNameUnitTest.php

@@ -40,6 +40,8 @@ public function getErrorList()
             30 => 1,
             40 => 1,
             41 => 1,
+            45 => 1,
+            47 => 1,
         ];
 
     }//end getErrorList()