Tests/FindImplementedInterfaceNamesTest: add extra tests

This adds some extra tests which were already in use in PHPCSUtils. This brings test coverage for this method up to 100%.

It also cleans up the test case file a little by removing some code which isn't actually used in the tests (namespace declaration) and moves the "class not implementing" test up.

Author: jrfnl

tests/Core/File/FindImplementedInterfaceNamesTest.inc

@@ -1,12 +1,14 @@
 <?php
 
-namespace PHP_CodeSniffer\Tests\Core\File;
-
-interface testFIINInterface2 {}
+/* testNotAClass */
+function notAClass() {}
 
 /* testPlainInterface */
 interface testFIINInterface {}
 
+/* testNonImplementedClass */
+class testFIINNonImplementedClass {}
+
 /* testClassImplementsSingle */
 class testFIINImplementedClass implements testFIINInterface {}
 
@@ -16,8 +18,8 @@ class testFIINMultiImplementedClass implements testFIINInterface, testFIINInterf
 /* testImplementsFullyQualified */
 class testFIINNamespacedClass implements \PHP_CodeSniffer\Tests\Core\File\testFIINInterface {}
 
-/* testNonImplementedClass */
-class testFIINNonImplementedClass {}
+/* testImplementsPartiallyQualified */
+class testFIINQualifiedClass implements Core\File\RelativeInterface {}
 
 /* testClassThatExtendsAndImplements */
 class testFECNClassThatExtendsAndImplements extends testFECNClass implements InterfaceA, \NameSpaced\Cat\InterfaceB {}
@@ -33,3 +35,13 @@ enum Suit implements Colorful {}
 
 /* testBackedEnumImplementsMulti */
 enum Suit: string implements Colorful, \Deck {}
+
+/* testAnonClassImplementsSingle */
+$anon = class() implements testFIINInterface {}
+
+/* testMissingImplementsName */
+class testMissingExtendsName implements { /* missing interface name */  } // Intentional parse error.
+
+// Intentional parse error. Has to be the last test in the file.
+/* testParseError */
+class testParseError implements testInterface

tests/Core/File/FindImplementedInterfaceNamesTest.php

@@ -20,6 +20,33 @@ class FindImplementedInterfaceNamesTest extends AbstractMethodUnitTest
 {
 
 
+    /**
+     * Test getting a `false` result when a non-existent token is passed.
+     *
+     * @return void
+     */
+    public function testNonExistentToken()
+    {
+        $result = self::$phpcsFile->findImplementedInterfaceNames(100000);
+        $this->assertFalse($result);
+
+    }//end testNonExistentToken()
+
+
+    /**
+     * Test getting a `false` result when a token other than one of the supported tokens is passed.
+     *
+     * @return void
+     */
+    public function testNotAClass()
+    {
+        $token  = $this->getTargetToken('/* testNotAClass */', [T_FUNCTION]);
+        $result = self::$phpcsFile->findImplementedInterfaceNames($token);
+        $this->assertFalse($result);
+
+    }//end testNotAClass()
+
+
     /**
      * Test retrieving the name(s) of the interfaces being implemented by a class.
      *
@@ -49,6 +76,14 @@ public function testFindImplementedInterfaceNames($identifier, $expected)
     public function dataImplementedInterface()
     {
         return [
+            'interface declaration, no implements'                               => [
+                'identifier' => '/* testPlainInterface */',
+                'expected'   => false,
+            ],
+            'class does not implement'                                           => [
+                'identifier' => '/* testNonImplementedClass */',
+                'expected'   => false,
+            ],
             'class implements single interface, unqualified'                     => [
                 'identifier' => '/* testClassImplementsSingle */',
                 'expected'   => ['testFIINInterface'],
@@ -64,13 +99,9 @@ public function dataImplementedInterface()
                 'identifier' => '/* testImplementsFullyQualified */',
                 'expected'   => ['\PHP_CodeSniffer\Tests\Core\File\testFIINInterface'],
             ],
-            'class does not implement'                                           => [
-                'identifier' => '/* testNonImplementedClass */',
-                'expected'   => false,
-            ],
-            'interface declaration, no implements'                               => [
-                'identifier' => '/* testPlainInterface */',
-                'expected'   => false,
+            'class implements single interface, partially qualified'             => [
+                'identifier' => '/* testImplementsPartiallyQualified */',
+                'expected'   => ['Core\File\RelativeInterface'],
             ],
             'class extends and implements'                                       => [
                 'identifier' => '/* testClassThatExtendsAndImplements */',
@@ -101,6 +132,18 @@ public function dataImplementedInterface()
                     '\Deck',
                 ],
             ],
+            'anon class implements single interface, unqualified'                => [
+                'identifier' => '/* testAnonClassImplementsSingle */',
+                'expected'   => ['testFIINInterface'],
+            ],
+            'parse error - implements keyword, but no interface name'            => [
+                'identifier' => '/* testMissingImplementsName */',
+                'expected'   => false,
+            ],
+            'parse error - live coding - no curly braces'                        => [
+                'identifier' => '/* testParseError */',
+                'expected'   => false,
+            ],
         ];
 
     }//end dataImplementedInterface()