Skip to content

Commit f6d4010

Browse files
committed
Generic/ExecutableFile: check files using short open echo tag
Includes unit tests.
1 parent ae4f33b commit f6d4010

File tree

5 files changed

+9
-1
lines changed

5 files changed

+9
-1
lines changed

package.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -568,6 +568,8 @@ http://pear.php.net/dtd/package-2.0.xsd">
568568
<file baseinstalldir="PHP/CodeSniffer" name="EndFileNoNewlineUnitTest.php" role="test" />
569569
<file baseinstalldir="PHP/CodeSniffer" name="ExecutableFileUnitTest.1.inc" role="test" />
570570
<file baseinstalldir="PHP/CodeSniffer" name="ExecutableFileUnitTest.2.inc" role="test" />
571+
<file baseinstalldir="PHP/CodeSniffer" name="ExecutableFileUnitTest.3.inc" role="test" />
572+
<file baseinstalldir="PHP/CodeSniffer" name="ExecutableFileUnitTest.4.inc" role="test" />
571573
<file baseinstalldir="PHP/CodeSniffer" name="ExecutableFileUnitTest.php" role="test" />
572574
<file baseinstalldir="PHP/CodeSniffer" name="InlineHTMLUnitTest.1.inc" role="test" />
573575
<file baseinstalldir="PHP/CodeSniffer" name="InlineHTMLUnitTest.2.inc" role="test" />

src/Standards/Generic/Sniffs/Files/ExecutableFileSniff.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@ class ExecutableFileSniff implements Sniff
2323
*/
2424
public function register()
2525
{
26-
return [T_OPEN_TAG];
26+
return [
27+
T_OPEN_TAG,
28+
T_OPEN_TAG_WITH_ECHO,
29+
];
2730

2831
}//end register()
2932

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
<?= 'text' ?>
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
<?= 'text' ?>

src/Standards/Generic/Tests/Files/ExecutableFileUnitTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public function getErrorList($testFile='')
4444
{
4545
switch ($testFile) {
4646
case 'ExecutableFileUnitTest.2.inc':
47+
case 'ExecutableFileUnitTest.4.inc':
4748
return [1 => 1];
4849
default:
4950
return [];

0 commit comments

Comments
 (0)