Generic/RequireStrictTypes: bug fix - limit token search to the statement

While hopefully unlikely in real life, the sniff should handle parse errors correctly.

Along the same lines, live coding should be handled correctly and a `declare()` statement should only be examined once the statement has been completed.

This updates the sniff to handle both situations correctly.
Without these fixes, no error would be thrown in test case file 5 or 6 (false negative), while an error would be thrown in test case file 7 (false positive).

Includes unit tests.

Includes minor efficiency tweak to only start looking for a "next" token _after_ the current token.

Author: jrfnl

CHANGELOG.md

@@ -109,6 +109,8 @@ The file documents changes to the PHP_CodeSniffer project.
     - Thanks to Volker Dusch (@edorian) for the patch
 - Fixed bug #3717 : Squiz.Commenting.FunctionComment: fixed false positive for InvalidNoReturn when type is never
     - Thanks to Choraimy Kroonstuiver (@axlon) for the patch
+- Fixed bug #3720 : Generic/RequireStrictTypes : will now bow out silently in case of parse errors/live coding instead of throwing false positives/false negatives
+    - Thanks to Juliette Reinders Folmer (@jrfnl) for the patch
 - Fixed bug #3722 : Potential "Uninitialized string offset 1" in octal notation backfill
     - Thanks to Juliette Reinders Folmer (@jrfnl) for the patch
 - Fixed bug #3728 : PHP 8.2 | PSR1/SideEffects: allow for readonly classes

src/Standards/Generic/Sniffs/PHP/RequireStrictTypesSniff.php

@@ -11,6 +11,7 @@
 
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Sniffs\Sniff;
+use PHP_CodeSniffer\Util\Tokens;
 
 class RequireStrictTypesSniff implements Sniff
 {
@@ -40,19 +41,31 @@ public function register()
     public function process(File $phpcsFile, $stackPtr)
     {
         $tokens  = $phpcsFile->getTokens();
-        $declare = $phpcsFile->findNext(T_DECLARE, $stackPtr);
-        $found   = false;
+        $declare = $phpcsFile->findNext(T_DECLARE, ($stackPtr + 1));
+
+        $found = false;
 
         if ($declare !== false) {
-            $nextString = $phpcsFile->findNext(T_STRING, $declare);
+            if (isset($tokens[$declare]['parenthesis_opener'], $tokens[$declare]['parenthesis_closer']) === false) {
+                // Live coding, ignore for now.
+                return $phpcsFile->numTokens;
+            }
 
-            if ($nextString !== false) {
-                if (strtolower($tokens[$nextString]['content']) === 'strict_types') {
-                    // There is a strict types declaration.
-                    $found = true;
-                }
+            $next = $phpcsFile->findNext(
+                Tokens::$emptyTokens,
+                ($tokens[$declare]['parenthesis_opener'] + 1),
+                $tokens[$declare]['parenthesis_closer'],
+                true
+            );
+
+            if ($next !== false
+                && $tokens[$next]['code'] === T_STRING
+                && strtolower($tokens[$next]['content']) === 'strict_types'
+            ) {
+                // There is a strict types declaration.
+                $found = true;
             }
-        }
+        }//end if
 
         if ($found === false) {
             $error = 'Missing required strict_types declaration';

src/Standards/Generic/Tests/PHP/RequireStrictTypesUnitTest.5.inc

@@ -0,0 +1,6 @@
+<?php
+
+// This is a parse error, but the sniff should still handle this correctly.
+declare($something = $value);
+
+const STRICT_TYPES = 1;

src/Standards/Generic/Tests/PHP/RequireStrictTypesUnitTest.6.inc

@@ -0,0 +1,4 @@
+<?php
+
+// This is a parse error, but the sniff should still handle this correctly.
+declare($something = STRICT_TYPES);

src/Standards/Generic/Tests/PHP/RequireStrictTypesUnitTest.7.inc

@@ -0,0 +1,4 @@
+<?php
+
+// Live coding. This should be ignored.
+declare(

src/Standards/Generic/Tests/PHP/RequireStrictTypesUnitTest.php

@@ -29,6 +29,8 @@ public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'RequireStrictTypesUnitTest.2.inc':
+        case 'RequireStrictTypesUnitTest.5.inc':
+        case 'RequireStrictTypesUnitTest.6.inc':
             return [1 => 1];
 
         default: