Modernize: AbstractVariableSniff: use class constant for constant array

As the property was in the public API, the class constant is also `protected` and the property has been deprecated, to be removed in PHPCS 5.0.

Author: jrfnl

src/Sniffs/AbstractVariableSniff.php

@@ -26,9 +26,9 @@ abstract class AbstractVariableSniff extends AbstractScopeSniff
      *
      * Used by various naming convention sniffs.
      *
-     * @var array
+     * @var array<string, true>
      */
-    protected $phpReservedVars = [
+    protected const PHP_RESERVED_VARS = [
         '_SERVER'              => true,
         '_GET'                 => true,
         '_POST'                => true,
@@ -43,6 +43,15 @@ abstract class AbstractVariableSniff extends AbstractScopeSniff
         'php_errormsg'         => true,
     ];
 
+    /**
+     * List of PHP Reserved variables.
+     *
+     * @var array<string, true>
+     *
+     * @deprecated 4.0.0 Use the AbstractVariableSniff::PHP_RESERVED_VARS constant instead.
+     */
+    protected $phpReservedVars = self::PHP_RESERVED_VARS;
+
 
     /**
      * Constructs an AbstractVariableTest.

src/Standards/Squiz/Sniffs/NamingConventions/ValidVariableNameSniff.php

@@ -34,7 +34,7 @@ protected function processVariable(File $phpcsFile, $stackPtr)
         $varName = ltrim($tokens[$stackPtr]['content'], '$');
 
         // If it's a php reserved var, then its ok.
-        if (isset($this->phpReservedVars[$varName]) === true) {
+        if (isset(static::PHP_RESERVED_VARS[$varName]) === true) {
             return;
         }
 
@@ -170,7 +170,7 @@ protected function processVariableInString(File $phpcsFile, $stackPtr)
         if (preg_match_all('|[^\\\]\${?([a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*)|', $tokens[$stackPtr]['content'], $matches) !== 0) {
             foreach ($matches[1] as $varName) {
                 // If it's a php reserved var, then its ok.
-                if (isset($this->phpReservedVars[$varName]) === true) {
+                if (isset(static::PHP_RESERVED_VARS[$varName]) === true) {
                     continue;
                 }
 

src/Standards/Zend/Sniffs/NamingConventions/ValidVariableNameSniff.php

@@ -34,7 +34,7 @@ protected function processVariable(File $phpcsFile, $stackPtr)
         $varName = ltrim($tokens[$stackPtr]['content'], '$');
 
         // If it's a php reserved var, then its ok.
-        if (isset($this->phpReservedVars[$varName]) === true) {
+        if (isset(static::PHP_RESERVED_VARS[$varName]) === true) {
             return;
         }
 
@@ -176,7 +176,7 @@ protected function processVariableInString(File $phpcsFile, $stackPtr)
         if (preg_match_all('|[^\\\]\$([a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*)|', $tokens[$stackPtr]['content'], $matches) !== 0) {
             foreach ($matches[1] as $varName) {
                 // If it's a php reserved var, then its ok.
-                if (isset($this->phpReservedVars[$varName]) === true) {
+                if (isset(static::PHP_RESERVED_VARS[$varName]) === true) {
                     continue;
                 }