-
-
Notifications
You must be signed in to change notification settings - Fork 89
Closed as not planned
Closed as not planned
Copy link
Labels
Description
Describe the bug
The Squiz ruleset has included BOTH Generic.NamingConventions.UpperCaseConstantName and Generic.PHP.LowerCaseConstant, which contradict each other. The former stipulates that true, false and null constants must always be uppercase, while the latter says that they must always be lowercase.
Which one should be followed, and why are both in the Squiz ruleset?
Code sample
From Squiz/ruleset.xml:
<rule ref="Generic.NamingConventions.UpperCaseConstantName"/>
<rule ref="Generic.PHP.LowerCaseConstant"/>
Versions (please complete the following information)
Operating System | Debian Linux |
PHP version | 8.2.24 |
PHP_CodeSniffer version | 3.11.3 |
Standard | Squiz |
Install type | Composer (local) |
Additional context
Add any other context about the problem here.
Please confirm
- I have searched the issue list and am not opening a duplicate issue.
- I have read the Contribution Guidelines and this is not a support question.
- I confirm that this bug is a bug in PHP_CodeSniffer and not in one of the external standards.
- I have verified the issue still exists in the
master
branch of PHP_CodeSniffer.