GH Actions/test: fix coverage runs #1085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two issues:
1. The PHPUnit coverage cache warming step was not being run for PHPUnit 10 or 11, while it should be.
2. The code coverage build against PHP 8.1 started failing after the merge of PR 871, which started polyfilling the tokens for PHP 8.4 asymmetric visibility. This failure was caused by the following error:
```
Message: Token T_PUBLIC_SET has ID of type string, should be int. You may be using a library with broken token emulation
Location: /home/runner/work/PHP_CodeSniffer/PHP_CodeSniffer/vendor/nikic/php-parser/lib/PhpParser/compatibility_tokens.php:35
```
All in all, this is the umpteenth time that PHP Parser is being a pain in the neck for us, but it is what it is.
Either way, this commit should fix it (again).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit fixes two issues:
All in all, this is the umpteenth time that PHP Parser is being a pain in the neck for us, but it is what it is.
Either way, this commit should fix it (again).
Suggested changelog entry
N/A