PHP 8.4 | PSR2/PropertyDeclaration: add support for abstract properties #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes handling the modifier order when `abstract` is used. This introduces a new `AbstractAfterVisibility` error code. Includes tests. Note: the modifier keyword order checks could probably do with some optimization, but that can be handled later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes handling the modifier order when
abstractis used. This introduces a newAbstractAfterVisibilityerror code.Includes tests.
Note: the modifier keyword order checks could probably do with some optimization, but that can be handled later.
Suggested changelog entry
Added support for PHP 8.4 abstract properties to the following sniffs:
PSR2.Classes.PropertyDeclaration
The PSR2.Classes.PropertyDeclaration will now check that the
abstractmodifier keyword is placed before a visibility keyword.AbstractAfterVisibilityerror code.Related issues/external references
Related to #734