diff --git a/src/Build/UpdateXsdFiles.php b/src/Build/UpdateXsdFiles.php index adc764a..ebaf3ea 100644 --- a/src/Build/UpdateXsdFiles.php +++ b/src/Build/UpdateXsdFiles.php @@ -142,7 +142,6 @@ private function getReleasesFallback(): void $releasesJson = \curl_exec($curl); if (\is_string($releasesJson) === false) { - \curl_close($curl); throw new RuntimeException('GitHub API request to retrieve the releases failed'); } @@ -150,12 +149,9 @@ private function getReleasesFallback(): void $latestReleaseJson = \curl_exec($curl); if (\is_string($latestReleaseJson) === false) { - \curl_close($curl); throw new RuntimeException('GitHub API request to retrieve the latest release failed'); } - \curl_close($curl); - $latestRelease = \json_decode($latestReleaseJson, flags: \JSON_THROW_ON_ERROR | \JSON_OBJECT_AS_ARRAY); $latestRelease = $latestRelease['tag_name']; @@ -230,7 +226,7 @@ private function getXsdFile(string $tagName): string { $url = \sprintf(self::XSD_URL, $tagName); $contents = \file_get_contents($url); - if (!$contents) { + if (is_string($contents) === false) { throw new RuntimeException(\sprintf('Failed to read XSD file: %s', $url)); }