Skip to content

Commit e49e95a

Browse files
committed
Ruleset: update property format
The old array format is deprecated since PHPCS 3.3.0 and is causing deprecation notices since PHPCS 3.13.0. The new array format was introduced in PHPCS 3.3.0, so this includes raising the minimum supported PHPCS version. Fixes 63
1 parent bcefd1e commit e49e95a

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

PHPCompatibilityWP/ruleset.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,9 @@
7979
<rule ref="PHPCompatibility.Extensions.RemovedExtensions">
8080
<properties>
8181
<!-- Contained in /wp-includes/functions.php. -->
82-
<property name="functionWhitelist" type="array" value="mysql_to_rfc3339"/>
82+
<property name="functionWhitelist" type="array">
83+
<element value="mysql_to_rfc3339"/>
84+
</property>
8385
</properties>
8486
</rule>
8587

README.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,9 @@ This WordPress specific ruleset prevents false positives from the [PHPCompatibil
1818
## Requirements
1919

2020
* [PHP_CodeSniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer).
21-
* PHP 5.3+ for use with [PHP_CodeSniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) 2.3.0+.
22-
* PHP 5.4+ for use with [PHP_CodeSniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) 3.0.2+.
21+
* PHP 5.4+ for use with [PHP_CodeSniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) 3.3.0+.
2322

2423
Use the latest stable release of PHP_CodeSniffer for the best results.
25-
The minimum _recommended_ version of PHP_CodeSniffer is version 2.6.0.
2624
* [PHPCompatibility](https://github.com/PHPCompatibility/PHPCompatibility) 9.0.0+.
2725
* [PHPCompatibilityParagonie](https://github.com/PHPCompatibility/PHPCompatibilityParagonie) 1.0.0+.
2826

@@ -34,7 +32,7 @@ The only supported installation method is via [Composer](https://getcomposer.org
3432
If you don't have a Composer plugin installed to manage the `installed_paths` setting for PHP_CodeSniffer, run the following from the command-line:
3533
```bash
3634
composer config allow-plugins.dealerdirect/phpcodesniffer-composer-installer true
37-
composer require --dev dealerdirect/phpcodesniffer-composer-installer:"^0.7" phpcompatibility/phpcompatibility-wp:"*"
35+
composer require --dev dealerdirect/phpcodesniffer-composer-installer:"^1.0" phpcompatibility/phpcompatibility-wp:"*"
3836
```
3937

4038
If you already have a Composer PHP_CodeSniffer plugin installed, run:
@@ -85,6 +83,11 @@ All code within the PHPCompatibility organisation is released under the GNU Less
8583

8684
## Changelog
8785

86+
### 2.1.7 - 2025-05-12
87+
88+
- Composer: The minimum supported version of PHP_CodeSniffer has been raised to 3.3.0.
89+
- Ruleset: Updated for compatibility with PHP_CodeSniffer 4.0+.
90+
8891
### 2.1.6 - 2025-01-16
8992

9093
- README: Fixed some broken badges.

composer.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"lock": false
2626
},
2727
"require" : {
28+
"squizlabs/php_codesniffer" : "^3.3",
2829
"phpcompatibility/php-compatibility" : "^9.0",
2930
"phpcompatibility/phpcompatibility-paragonie" : "^1.0"
3031
},

0 commit comments

Comments
 (0)