#272 : ODPresentation Writer : Show/Hide Value / Name / Series Name in Chart

Author: Progi1984

CHANGELOG.md

@@ -12,6 +12,7 @@
 - PowerPoint2007 Writer : Support of margins in cell in table - @carlosafonso @Progi1984 GH-273 GH-315
 
 ### Features
+- ODPresentation Writer : Show/Hide Value / Name / Series Name in Chart - @Progi1984 GH-272
 - PowerPoint2007 Writer : Implement character spacing - @jvanoostrom GH-301
 
 ## 0.7.0 - 2016-09-12

src/PhpPresentation/Writer/ODPresentation/ObjectsChart.php

@@ -651,7 +651,20 @@ private function writeSeriesStyle(Chart $chart, Chart\Series $series)
         $this->xmlContent->writeAttribute('style:family', 'chart');
         // style:chart-properties
         $this->xmlContent->startElement('style:chart-properties');
-        $this->xmlContent->writeAttribute('chart:data-label-number', 'value');
+        if ($series->hasShowValue()) {
+            if ($series->hasShowPercentage()) {
+                $this->xmlContent->writeAttribute('chart:data-label-number', 'value-and-percentage');
+            } else {
+                $this->xmlContent->writeAttribute('chart:data-label-number', 'value');
+            }
+        } else {
+            if ($series->hasShowPercentage()) {
+                $this->xmlContent->writeAttribute('chart:data-label-number', 'percentage');
+            }
+        }
+        if ($series->hasShowCategoryName()) {
+            $this->xmlContent->writeAttribute('chart:data-label-text', 'true');
+        }
         $this->xmlContent->writeAttribute('chart:label-position', 'center');
         if ($chartType instanceof AbstractTypePie) {
             $this->xmlContent->writeAttribute('chart:pie-offset', $chartType->getExplosion());

tests/PhpPresentation/Tests/Writer/ODPresentation/ObjectsChartTest.php

@@ -666,4 +666,56 @@ public function testTypeScatterSeriesOutline()
         $this->assertZipXmlAttributeExists('Object 1/content.xml', $expectedElement, 'svg:stroke-color');
         $this->assertZipXmlAttributeEquals('Object 1/content.xml', $expectedElement, 'svg:stroke-color', '#' . $oColor->getRGB());
     }
+
+    public function testSeries()
+    {
+        $oSeries = new Series('Series', array('Jan' => 1, 'Feb' => 5, 'Mar' => 2));
+        $oPie = new Pie();
+        $oPie->addSeries($oSeries);
+        $oChart = $this->oPresentation->getActiveSlide()->createChartShape();
+        $oChart->getPlotArea()->setType($oPie);
+
+        $element = '/office:document-content/office:automatic-styles/style:style[@style:name=\'styleSeries0\']/style:chart-properties';
+
+        // $showCategoryName = false / $showPercentage = false / $showValue = true
+        $this->assertZipXmlElementExists('Object 1/content.xml', $element);
+        $this->assertZipXmlAttributeExists('Object 1/content.xml', $element, 'chart:data-label-number');
+        $this->assertZipXmlAttributeEquals('Object 1/content.xml', $element, 'chart:data-label-number', 'value');
+        $this->assertZipXmlAttributeNotExists('Object 1/content.xml', $element, 'chart:data-label-text');
+
+        $oSeries->setShowValue(false);
+        $this->resetPresentationFile();
+
+        // $showCategoryName = false / $showPercentage = false / $showValue = false
+        $this->assertZipXmlElementExists('Object 1/content.xml', $element);
+        $this->assertZipXmlAttributeNotExists('Object 1/content.xml', $element, 'chart:data-label-number');
+        $this->assertZipXmlAttributeNotExists('Object 1/content.xml', $element, 'chart:data-label-text');
+
+        // $showCategoryName = false / $showPercentage = true / $showValue = true
+        $oSeries->setShowValue(true);
+        $oSeries->setShowPercentage(true);
+        $this->resetPresentationFile();
+
+        $this->assertZipXmlElementExists('Object 1/content.xml', $element);
+        $this->assertZipXmlAttributeExists('Object 1/content.xml', $element, 'chart:data-label-number');
+        $this->assertZipXmlAttributeEquals('Object 1/content.xml', $element, 'chart:data-label-number', 'value-and-percentage');
+        $this->assertZipXmlAttributeNotExists('Object 1/content.xml', $element, 'chart:data-label-text');
+
+        // $showCategoryName = false / $showPercentage = true / $showValue = false
+        $oSeries->setShowValue(false);
+        $this->resetPresentationFile();
+
+        $this->assertZipXmlElementExists('Object 1/content.xml', $element);
+        $this->assertZipXmlAttributeExists('Object 1/content.xml', $element, 'chart:data-label-number');
+        $this->assertZipXmlAttributeEquals('Object 1/content.xml', $element, 'chart:data-label-number', 'percentage');
+        $this->assertZipXmlAttributeNotExists('Object 1/content.xml', $element, 'chart:data-label-text');
+
+        // $showCategoryName = false / $showPercentage = true / $showValue = false
+        $oSeries->setShowCategoryName(true);
+        $this->resetPresentationFile();
+
+        $this->assertZipXmlElementExists('Object 1/content.xml', $element);
+        $this->assertZipXmlAttributeExists('Object 1/content.xml', $element, 'chart:data-label-text');
+        $this->assertZipXmlAttributeEquals('Object 1/content.xml', $element, 'chart:data-label-text', 'true');
+    }
 }