#634 : Adding Strict Types

Author: Progi1984

src/PhpPresentation/AbstractShape.php

@@ -16,6 +16,8 @@
  * @license     http://www.gnu.org/licenses/lgpl.txt LGPL version 3
  */
 
+declare(strict_types=1);
+
 namespace PhpOffice\PhpPresentation;
 
 use PhpOffice\PhpPresentation\Shape\Hyperlink;

src/PhpPresentation/Autoloader.php

@@ -16,6 +16,8 @@
  * @license     http://www.gnu.org/licenses/lgpl.txt LGPL version 3
  */
 
+declare(strict_types=1);
+
 namespace PhpOffice\PhpPresentation;
 
 /**
@@ -43,6 +45,9 @@ public static function autoload(string $class): void
         if (0 === strncmp(self::NAMESPACE_PREFIX, $class, $prefixLength)) {
             $file = str_replace('\\', DIRECTORY_SEPARATOR, substr($class, $prefixLength));
             $file = realpath(__DIR__ . (empty($file) ? '' : DIRECTORY_SEPARATOR) . $file . '.php');
+            if (!$file) {
+                return;
+            }
             if (file_exists($file)) {
                 /** @noinspection PhpIncludeInspection Dynamic includes */
                 require_once $file;

src/PhpPresentation/ComparableInterface.php

@@ -16,6 +16,8 @@
  * @license     http://www.gnu.org/licenses/lgpl.txt LGPL version 3
  */
 
+declare(strict_types=1);
+
 namespace PhpOffice\PhpPresentation;
 
 /**

src/PhpPresentation/DocumentLayout.php

@@ -16,6 +16,8 @@
  * @license     http://www.gnu.org/licenses/lgpl.txt LGPL version 3
  */
 
+declare(strict_types=1);
+
 namespace PhpOffice\PhpPresentation;
 
 use PhpOffice\Common\Drawing;
@@ -224,7 +226,7 @@ protected function convertUnit(float $value, string $fromUnit, string $toUnit):
                 $value /= 914400;
                 break;
             case self::UNIT_PIXEL:
-                $value = Drawing::emuToPixels($value);
+                $value = Drawing::emuToPixels((int) $value);
                 break;
             case self::UNIT_POINT:
                 $value /= 12700;

src/PhpPresentation/DocumentProperties.php

@@ -16,6 +16,8 @@
  * @license     http://www.gnu.org/licenses/lgpl.txt LGPL version 3
  */
 
+declare(strict_types=1);
+
 namespace PhpOffice\PhpPresentation;
 
 /**
@@ -398,9 +400,9 @@ public function isCustomPropertySet(string $propertyName): bool
      *
      * @param string $propertyName
      *
-     * @return string|null
+     * @return mixed|null
      */
-    public function getCustomPropertyValue(string $propertyName): ?string
+    public function getCustomPropertyValue(string $propertyName)
     {
         if ($this->isCustomPropertySet($propertyName)) {
             return $this->customProperties[$propertyName]['value'];

src/PhpPresentation/GeometryCalculator.php

@@ -16,6 +16,8 @@
  * @license     http://www.gnu.org/licenses/lgpl.txt LGPL version 3
  */
 
+declare(strict_types=1);
+
 namespace PhpOffice\PhpPresentation;
 
 /**

src/PhpPresentation/HashTable.php

@@ -16,6 +16,8 @@
  * @license     http://www.gnu.org/licenses/lgpl.txt LGPL version 3
  */
 
+declare(strict_types=1);
+
 namespace PhpOffice\PhpPresentation;
 
 /**

src/PhpPresentation/IOFactory.php

@@ -16,6 +16,8 @@
  * @license     http://www.gnu.org/licenses/lgpl.txt LGPL version 3
  */
 
+declare(strict_types=1);
+
 namespace PhpOffice\PhpPresentation;
 
 use PhpOffice\PhpPresentation\Reader\ReaderInterface;
@@ -51,7 +53,7 @@ public static function createWriter(PhpPresentation $phpPresentation, string $na
      *
      * @throws \Exception
      */
-    public static function createReader(string $name = ''): ReaderInterface
+    public static function createReader(string $name): ReaderInterface
     {
         $class = 'PhpOffice\\PhpPresentation\\Reader\\' . $name;
 

src/PhpPresentation/PhpPresentation.php

@@ -16,6 +16,8 @@
  * @license     http://www.gnu.org/licenses/lgpl.txt LGPL version 3
  */
 
+declare(strict_types=1);
+
 namespace PhpOffice\PhpPresentation;
 
 use ArrayObject;

src/PhpPresentation/PresentationProperties.php

@@ -16,6 +16,8 @@
  * @license     http://www.gnu.org/licenses/lgpl.txt LGPL version 3
  */
 
+declare(strict_types=1);
+
 namespace PhpOffice\PhpPresentation;
 
 class PresentationProperties