Skip to content

Commit d04b0f4

Browse files
committed
Refactor: Change PHPPowerPoint_Shape_Shadow to PHPPowerPoint_Style_Shadow
1 parent 3652b1e commit d04b0f4

File tree

3 files changed

+18
-17
lines changed

3 files changed

+18
-17
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
- QA: Initiate unit tests - @Progi1984 @ivanlanin
4343
- QA: Cleanup source code for PSR dan PHPDoc compatibility - @ivanlanin
4444
- Doc: Initiate documentation - @ivanlanin
45+
- Refactor: Change PHPPowerPoint_Shape_Shadow to PHPPowerPoint_Style_Shadow because it's a style, not a shape - @ivanlanin
4546

4647
## 0.1.0
4748

Classes/PHPPowerPoint/Shape.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ abstract class PHPPowerPoint_Shape implements PHPPowerPoint_IComparable
9393
/**
9494
* Shadow
9595
*
96-
* @var PHPPowerPoint_Shape_Shadow
96+
* @var PHPPowerPoint_Style_Shadow
9797
*/
9898
protected $_shadow;
9999

@@ -118,7 +118,7 @@ public function __construct()
118118
$this->_rotation = 0;
119119
$this->_fill = new PHPPowerPoint_Style_Fill();
120120
$this->_border = new PHPPowerPoint_Style_Border();
121-
$this->_shadow = new PHPPowerPoint_Shape_Shadow();
121+
$this->_shadow = new PHPPowerPoint_Style_Shadow();
122122

123123
$this->_border->setLineStyle(PHPPowerPoint_Style_Border::LINE_NONE);
124124
}
@@ -324,7 +324,7 @@ public function getBorder()
324324
/**
325325
* Get Shadow
326326
*
327-
* @return PHPPowerPoint_Shape_Shadow
327+
* @return PHPPowerPoint_Style_Shadow
328328
*/
329329
public function getShadow()
330330
{
@@ -334,11 +334,11 @@ public function getShadow()
334334
/**
335335
* Set Shadow
336336
*
337-
* @param PHPPowerPoint_Shape_Shadow $pValue
337+
* @param PHPPowerPoint_Style_Shadow $pValue
338338
* @throws Exception
339339
* @return PHPPowerPoint_Shape
340340
*/
341-
public function setShadow(PHPPowerPoint_Shape_Shadow $pValue = null)
341+
public function setShadow(PHPPowerPoint_Style_Shadow $pValue = null)
342342
{
343343
$this->_shadow = $pValue;
344344

Classes/PHPPowerPoint/Shape/Shadow.php renamed to Classes/PHPPowerPoint/Style/Shadow.php

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,20 +19,20 @@
1919
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
2020
*
2121
* @category PHPPowerPoint
22-
* @package PHPPowerPoint_Shape
22+
* @package PHPPowerPoint_Style
2323
* @copyright Copyright (c) 2009 - 2010 PHPPowerPoint (http://www.codeplex.com/PHPPowerPoint)
2424
* @license http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt LGPL
2525
* @version ##VERSION##, ##DATE##
2626
*/
2727

2828
/**
29-
* PHPPowerPoint_Shape_Shadow
29+
* PHPPowerPoint_Style_Shadow
3030
*
3131
* @category PHPPowerPoint
32-
* @package PHPPowerPoint_Shape
32+
* @package PHPPowerPoint_Style
3333
* @copyright Copyright (c) 2009 - 2010 PHPPowerPoint (http://www.codeplex.com/PHPPowerPoint)
3434
*/
35-
class PHPPowerPoint_Shape_Shadow implements PHPPowerPoint_IComparable
35+
class PHPPowerPoint_Style_Shadow implements PHPPowerPoint_IComparable
3636
{
3737
/* Shadow alignment */
3838
const SHADOW_BOTTOM = 'b';
@@ -98,7 +98,7 @@ class PHPPowerPoint_Shape_Shadow implements PHPPowerPoint_IComparable
9898
private $_alpha;
9999

100100
/**
101-
* Create a new PHPPowerPoint_Shape_Shadow
101+
* Create a new PHPPowerPoint_Style_Shadow
102102
*/
103103
public function __construct()
104104
{
@@ -126,7 +126,7 @@ public function getVisible()
126126
* Set Visible
127127
*
128128
* @param boolean $pValue
129-
* @return PHPPowerPoint_Shape_Shadow
129+
* @return self
130130
*/
131131
public function setVisible($pValue = false)
132132
{
@@ -149,7 +149,7 @@ public function getBlurRadius()
149149
* Set Blur radius
150150
*
151151
* @param int $pValue
152-
* @return PHPPowerPoint_Shape_Shadow
152+
* @return self
153153
*/
154154
public function setBlurRadius($pValue = 6)
155155
{
@@ -172,7 +172,7 @@ public function getDistance()
172172
* Set Shadow distance
173173
*
174174
* @param int $pValue
175-
* @return PHPPowerPoint_Shape_Shadow
175+
* @return self
176176
*/
177177
public function setDistance($pValue = 2)
178178
{
@@ -195,7 +195,7 @@ public function getDirection()
195195
* Set Shadow direction (in degrees)
196196
*
197197
* @param int $pValue
198-
* @return PHPPowerPoint_Shape_Shadow
198+
* @return self
199199
*/
200200
public function setDirection($pValue = 0)
201201
{
@@ -218,7 +218,7 @@ public function getAlignment()
218218
* Set Shadow alignment
219219
*
220220
* @param int $pValue
221-
* @return PHPPowerPoint_Shape_Shadow
221+
* @return self
222222
*/
223223
public function setAlignment($pValue = 0)
224224
{
@@ -242,7 +242,7 @@ public function getColor()
242242
*
243243
* @param PHPPowerPoint_Style_Color $pValue
244244
* @throws Exception
245-
* @return PHPPowerPoint_Shape_Shadow
245+
* @return self
246246
*/
247247
public function setColor(PHPPowerPoint_Style_Color $pValue = null)
248248
{
@@ -265,7 +265,7 @@ public function getAlpha()
265265
* Set Alpha
266266
*
267267
* @param int $pValue
268-
* @return PHPPowerPoint_Shape_Shadow
268+
* @return self
269269
*/
270270
public function setAlpha($pValue = 0)
271271
{

0 commit comments

Comments
 (0)