Merge pull request #1511 from carusogabriel/ternary-expressions

Remove unnecessary ternary expressions

Author: troosan

src/PhpWord/Metadata/DocInfo.php

@@ -507,7 +507,7 @@ public static function convertProperty($propertyValue, $propertyType)
             case 'date': // Date
                 return strtotime($propertyValue);
             case 'bool': // Boolean
-                return ($propertyValue == 'true') ? true : false;
+                return $propertyValue == 'true';
         }
 
         return $propertyValue;

src/PhpWord/Reader/MsDoc.php

@@ -1619,7 +1619,7 @@ private function readPrl($data, $pos, $cbNum)
                             break;
                         // sprmCFData
                         case 0x06:
-                            $sprmCFData = dechex($operand) == 0x00 ? false : true;
+                            $sprmCFData = dechex($operand) != 0x00;
                             break;
                         // sprmCFItalic
                         case 0x36:

src/PhpWord/Reader/Word2007/AbstractPart.php

@@ -338,7 +338,7 @@ protected function readTable(XMLReader $xmlReader, \DOMElement $domNode, $parent
             } elseif ('w:tr' == $tblNode->nodeName) { // Row
                 $rowHeight = $xmlReader->getAttribute('w:val', $tblNode, 'w:trPr/w:trHeight');
                 $rowHRule = $xmlReader->getAttribute('w:hRule', $tblNode, 'w:trPr/w:trHeight');
-                $rowHRule = $rowHRule == 'exact' ? true : false;
+                $rowHRule = $rowHRule == 'exact';
                 $rowStyle = array(
                     'tblHeader'   => $xmlReader->elementExists('w:trPr/w:tblHeader', $tblNode),
                     'cantSplit'   => $xmlReader->elementExists('w:trPr/w:cantSplit', $tblNode),

src/PhpWord/Shared/ZipArchive.php

@@ -258,7 +258,7 @@ public function pclzipAddFile($filename, $localname = null)
             unlink($this->tempDir . DIRECTORY_SEPARATOR . $localnameParts['basename']);
         }
 
-        return ($res == 0) ? false : true;
+        return $res != 0;
     }
 
     /**
@@ -289,7 +289,7 @@ public function pclzipAddFromString($localname, $contents)
         // Remove temp file
         @unlink($this->tempDir . DIRECTORY_SEPARATOR . $filenameParts['basename']);
 
-        return ($res == 0) ? false : true;
+        return $res != 0;
     }
 
     /**
@@ -309,7 +309,7 @@ public function pclzipExtractTo($destination, $entries = null)
         if (is_null($entries)) {
             $result = $zip->extract(PCLZIP_OPT_PATH, $destination);
 
-            return ($result > 0) ? true : false;
+            return $result > 0;
         }
 
         // Extract by entries

tests/PhpWord/_includes/XmlDocument.php

@@ -163,7 +163,7 @@ public function elementExists($path, $file = 'word/document.xml')
     {
         $nodeList = $this->getNodeList($path, $file);
 
-        return !($nodeList->length == 0);
+        return $nodeList->length != 0;
     }
 
     /**