Skip to content

Commit 376c990

Browse files
committed
Fixing more PHPStan Access to undefined property
1 parent 2c5bdca commit 376c990

File tree

2 files changed

+21
-11
lines changed

2 files changed

+21
-11
lines changed

tests/PhpWordTests/Writer/HTML/Element/TableTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ public function testWriteTableCellVAlign(): void
200200
$cell3Query = $xpath->query('//table/tr/td[3]');
201201
self::assertNotFalse($cell3Query);
202202
self::assertCount(1, $cell3Query);
203-
self::assertObjectHasProperty('attributes', $cell3Query->item(0));
203+
self::assertInstanceOf(DOMNode::class, $cell3Query->item(0));
204204
$cell3Style = $cell3Query->item(0)->attributes->getNamedItem('style');
205205
self::assertNull($cell3Style);
206206
}

tests/PhpWordTests/Writer/HTML/ElementTest.php

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
use DateTime;
2222
use DOMDocument;
23+
use DOMNode;
2324
use DOMXPath;
2425
use PhpOffice\PhpWord\Element\Text as TextElement;
2526
use PhpOffice\PhpWord\Element\TextRun;
@@ -107,16 +108,18 @@ public function testWriteColSpan(): void
107108

108109
$query = $xpath->query('/html/body/div/table/tr[1]/td');
109110
self::assertNotFalse($query);
110-
self::assertEquals(1, $query->length);
111-
self::assertEquals('2', $xpath->query('/html/body/div/table/tr/td[1]')->item(0)->attributes->getNamedItem('colspan')->textContent);
111+
self::assertCount(1, $query);
112+
self::assertInstanceOf(DOMNode::class, $query->item(0));
113+
self::assertEquals('2', $query->item(0)->attributes->getNamedItem('colspan')->textContent);
114+
self::assertEquals('#6086B8', $query->item(0)->attributes->getNamedItem('bgcolor')->textContent);
115+
self::assertEquals('#ffffff', $query->item(0)->attributes->getNamedItem('color')->textContent);
116+
112117
$query = $xpath->query('/html/body/div/table/tr[2]/td');
113118
self::assertNotFalse($query);
114-
self::assertEquals(2, $query->length);
115-
116-
self::assertEquals('#6086B8', $xpath->query('/html/body/div/table/tr[1]/td')->item(0)->attributes->getNamedItem('bgcolor')->textContent);
117-
self::assertEquals('#ffffff', $xpath->query('/html/body/div/table/tr[1]/td')->item(0)->attributes->getNamedItem('color')->textContent);
118-
self::assertEquals('#ffffff', $xpath->query('/html/body/div/table/tr[2]/td')->item(0)->attributes->getNamedItem('bgcolor')->textContent);
119-
self::assertNull($xpath->query('/html/body/div/table/tr[2]/td')->item(0)->attributes->getNamedItem('color'));
119+
self::assertCount(2, $query);
120+
self::assertInstanceOf(DOMNode::class, $query->item(0));
121+
self::assertEquals('#ffffff', $query->item(0)->attributes->getNamedItem('bgcolor')->textContent);
122+
self::assertNull($query->item(0)->attributes->getNamedItem('color'));
120123
}
121124

122125
/**
@@ -145,8 +148,15 @@ public function testWriteRowSpan(): void
145148

146149
$query = $xpath->query('/html/body/div/table/tr[1]/td');
147150
self::assertNotFalse($query);
148-
self::assertEquals(2, $query->length);
149-
self::assertEquals('3', $xpath->query('/html/body/div/table/tr[1]/td[1]')->item(0)->attributes->getNamedItem('rowspan')->textContent);
151+
self::assertCount(2, $query);
152+
self::assertInstanceOf(DOMNode::class, $query->item(0));
153+
self::assertEquals('2', $query->item(0)->attributes->getNamedItem('colspan')->textContent);
154+
155+
$query = $xpath->query('/html/body/div/table/tr[1]/td[1]');
156+
self::assertNotFalse($query);
157+
self::assertInstanceOf(DOMNode::class, $query->item(0));
158+
self::assertEquals('3', $query->item(0)->attributes->getNamedItem('rowspan')->textContent);
159+
150160
$query = $xpath->query('/html/body/div/table/tr[2]/td');
151161
self::assertNotFalse($query);
152162
self::assertEquals(1, $query->length);

0 commit comments

Comments
 (0)