Skip to content

Commit 47fa1f0

Browse files
committed
Bugfix: Preserve text doesn't render correctly when the text is not the first word, e.g. 'Page {PAGE}'
1 parent e89f24f commit 47fa1f0

File tree

7 files changed

+7
-6
lines changed

7 files changed

+7
-6
lines changed

Classes/PHPWord/Section/Footer/PreserveText.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public function __construct($text = null, $styleFont = null, $styleParagraph = n
9393

9494
$matches = preg_split('/({.*?})/', $text, null, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
9595
if (isset($matches[0])) {
96-
$this->_text = $matches[0];
96+
$this->_text = $matches;
9797
}
9898

9999
return $this;

Tests/PHPWord/Section/Footer/PreserveTextTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public function testConstruct()
1818
public function testConstructWithString()
1919
{
2020
$oPreserveText = new PHPWord_Section_Footer_PreserveText('text', 'styleFont', 'styleParagraph');
21-
$this->assertEquals($oPreserveText->getText(), 'text');
21+
$this->assertEquals($oPreserveText->getText(), array('text'));
2222
$this->assertEquals($oPreserveText->getFontStyle(), 'styleFont');
2323
$this->assertEquals($oPreserveText->getParagraphStyle(), 'styleParagraph');
2424
}

Tests/PHPWord/Section/FooterTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public function testAddPreserveTextNotUTF8()
110110

111111
$this->assertCount(1, $oFooter->getElements());
112112
$this->assertInstanceOf('PHPWord_Section_Footer_PreserveText', $element);
113-
$this->assertEquals($element->getText(), 'ééé');
113+
$this->assertEquals($element->getText(), array('ééé'));
114114
}
115115

116116
public function testGetElements()

Tests/PHPWord/Section/HeaderTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public function testAddPreserveTextNotUTF8()
106106

107107
$this->assertCount(1, $oHeader->getElements());
108108
$this->assertInstanceOf('PHPWord_Section_Footer_PreserveText', $element);
109-
$this->assertEquals($element->getText(), 'ééé');
109+
$this->assertEquals($element->getText(), array('ééé'));
110110
}
111111

112112
public function testAddWatermark()

Tests/PHPWord/Section/Table/CellTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ public function testAddPreserveTextNotUTF8()
188188

189189
$this->assertCount(1, $oCell->getElements());
190190
$this->assertInstanceOf('PHPWord_Section_Footer_PreserveText', $element);
191-
$this->assertEquals($element->getText(), 'ééé');
191+
$this->assertEquals($element->getText(), array('ééé'));
192192
}
193193

194194
public function testCreateTextRun()

changelog.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
**************************************************************************************
2424

2525
Changes in branch for release 0.9.0 :
26+
- Bugfix: (ivanlanin) - Preserve text doesn't render correctly when the text is not the first word, e.g. 'Page {PAGE}'
2627
- QA: (Progi1984) - Documentation
2728

2829
Changes in branch for release 0.8.1 :

samples/Sample_12_HeaderFooter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
// Add footer
2727
$footer = $section->createFooter();
28-
$footer->addPreserveText('Page {PAGE} of {NUMPAGES}.', array('align' => 'center'));
28+
$footer->addPreserveText('Page {PAGE} of {NUMPAGES}', array('color' => 'FF0000'), array('align' => 'center'));
2929

3030
// Write some text
3131
$section->addTextBreak();

0 commit comments

Comments
 (0)