Skip to content

Commit 64a6505

Browse files
authored
Merge pull request #578 from ComputerTinker/develop
#574 Incorrect Constant Names in \Style\Font.php
2 parents 610d91e + e929610 commit 64a6505

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/PhpWord/Reader/MsDoc.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1698,7 +1698,7 @@ private function readPrl($data, $pos, $cbNum)
16981698
$oStylePrl->styleFont['underline'] = Style\Font::UNDERLINE_DASH;
16991699
break;
17001700
case 0x09:
1701-
$oStylePrl->styleFont['underline'] = Style\Font::UNDERLINE_DOTHASH;
1701+
$oStylePrl->styleFont['underline'] = Style\Font::UNDERLINE_DOTDASH;
17021702
break;
17031703
case 0x0A:
17041704
$oStylePrl->styleFont['underline'] = Style\Font::UNDERLINE_DOTDOTDASH;
@@ -1713,7 +1713,7 @@ private function readPrl($data, $pos, $cbNum)
17131713
$oStylePrl->styleFont['underline'] = Style\Font::UNDERLINE_DASHHEAVY;
17141714
break;
17151715
case 0x19:
1716-
$oStylePrl->styleFont['underline'] = Style\Font::UNDERLINE_DOTHASHHEAVY;
1716+
$oStylePrl->styleFont['underline'] = Style\Font::UNDERLINE_DOTDASHHEAVY;
17171717
break;
17181718
case 0x1A:
17191719
$oStylePrl->styleFont['underline'] = Style\Font::UNDERLINE_DOTDOTDASHHEAVY;

src/PhpWord/Style/Font.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,10 @@ class Font extends AbstractStyle
3333
const UNDERLINE_DASHLONG = 'dashLong';
3434
const UNDERLINE_DASHLONGHEAVY = 'dashLongHeavy';
3535
const UNDERLINE_DOUBLE = 'dbl';
36-
const UNDERLINE_DOTHASH = 'dotDash';
37-
const UNDERLINE_DOTHASHHEAVY = 'dotDashHeavy';
36+
const UNDERLINE_DOTHASH = 'dotDash'; // Incorrect spelling, for backwards compatibility
37+
const UNDERLINE_DOTHASHHEAVY = 'dotDashHeavy'; // Incorrect spelling, for backwards compatibility
38+
const UNDERLINE_DOTDASH = 'dotDash'; // Correct spelling
39+
const UNDERLINE_DOTDASHHEAVY = 'dotDashHeavy'; // Correct spelling
3840
const UNDERLINE_DOTDOTDASH = 'dotDotDash';
3941
const UNDERLINE_DOTDOTDASHHEAVY = 'dotDotDashHeavy';
4042
const UNDERLINE_DOTTED = 'dotted';

0 commit comments

Comments
 (0)