Prevented fatal errors when opening corrupt files or "doc" files

Author: mmcev106

src/PhpWord/Shared/XMLReader.php

@@ -61,7 +61,15 @@ public function getDomFromZip($zipFile, $xmlFile)
         }
 
         $zip = new ZipArchive();
-        $zip->open($zipFile);
+        $openStatus = $zip->open($zipFile);
+        if($openStatus !== true){
+            /**
+             * Throw an exception since making further calls on the ZipArchive would cause a fatal error.
+             * This prevents fatal errors on corrupt archives and attempts to open old "doc" files.
+             */
+            throw new Exception("The archive failed to load with the following error code: $openStatus");
+        }
+
         $content = $zip->getFromName(ltrim($xmlFile, '/'));
         $zip->close();
 

tests/PhpWordTests/Shared/XMLReaderTest.php

@@ -85,6 +85,30 @@ public function testThrowsExceptionOnNonExistingArchive(): void
         $reader->getDomFromZip($archiveFile, 'test.xml');
     }
 
+    /**
+     * Test that read from invalid archive throws exception.
+     */
+    public function testThrowsExceptionOnZipArchiveOpenErrors(): void
+    {
+        $tempPath = tempnam(sys_get_temp_dir(), 'PhpWord');
+
+        // Simulate a corrupt archive
+        file_put_contents($tempPath, rand());
+
+        $exceptionMessage = null;
+        try{
+            $reader = new XMLReader();
+            $reader->getDomFromZip($tempPath, 'test.xml');
+        }
+        catch(\Exception $e){
+            $exceptionMessage = $e->getMessage();
+        }
+
+        $this->assertNotNull($exceptionMessage);
+
+        unlink($tempPath);
+    }
+
     /**
      * Test elements count.
      */