Enforce valid value for on/off type

Trainmaster · troosan · commit f41c542ba07e · 2018-03-07T07:01:54.000+01:00
diff --git a/src/PhpWord/Writer/Word2007/Part/Settings.php b/src/PhpWord/Writer/Word2007/Part/Settings.php
@@ -174,11 +174,8 @@ private function setOnOffValue($settingName, $booleanValue)
             return;
         }
 
-        if ($booleanValue) {
-            $this->settings[$settingName] = array('@attributes' => array());
-        } else {
-            $this->settings[$settingName] = array('@attributes' => array('w:val' => 'false'));
-        }
+        $value = $booleanValue ? 'true' : 'false';
+        $this->settings[$settingName] = array('@attributes' => array('w:val' => $value));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -174,11 +174,8 @@ private function setOnOffValue($settingName, $booleanValue)`
`174`	`174`	`return;`
`175`	`175`	`}`
`176`	`176`
`177`		`- if ($booleanValue) {`
`178`		`- $this->settings[$settingName] = array('@attributes' => array());`
`179`		`- } else {`
`180`		`- $this->settings[$settingName] = array('@attributes' => array('w:val' => 'false'));`
`181`		`- }`
	`177`	`+ $value = $booleanValue ? 'true' : 'false';`
	`178`	`+ $this->settings[$settingName] = array('@attributes' => array('w:val' => $value));`
`182`	`179`	`}`
`183`	`180`
`184`	`181`	`/**`