WIP Do Not Install #2567
Draft
WIP Do Not Install #2567
+2,960
−294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All my unimplemented changes. Not intended for install.
Better from a technical standpoint. Pre-processing much simplified. Some post-processing added because loadHTML preserveWhiteSpace=false does not work well. Not-UTF8 html can now be loaded. No need to surround snippets with body tag.
It's debatable, but allow unescaped ampersand and unknown charset.
Couldn't resolve a good version for mpdf.
Dompdf (temporary till 8.5-compatible release available), `chr` in Reader/MsDoc, `setAccessible` in AbstractStyleTest.
Sample_11_ReadWord2007 reads a file with color=auto, and RTF Writer doesn't handle it properly. Change to treat it as black.
Still not out of the woods. Write to Docx and Odt are fine. Write to RTF and HTML are fine only if they follow write to ODT.
RTF now works. In the process of saving, ODText creates a lot of new styles. Because it was being done before RTF and HTML in the samples, it was masking problems in the other formats. It is now changed to happen after the other formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All my unimplemented changes. Not intended for install.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Checklist:
composer run-script check --timeout=0and no errors were reported