RTF: Add Missing Font Features #2819
Open
+100
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In combination with next edit... Sets the fgColor and bgColor according to the colorTable.
Adds underline styles, doublestrikethrough, smallcaps, allcaps, fgcolor, hidden, scall, spacing, kerning, position, noproof, and bgcolor.
Now that Font isn't returning unnecessary values, it could sometimes occur where it returned an extra space in the document if ($content == ''). This is fixed.
In these cases, the array_search should always return an integer, but because the php static analysis tests didn't like the chance that it might return a string, let's explicitly cast the variable as an integer.
|
This may fix #321? I'm not sure what the bug report means by "export", but I assume they are talking about the RTF Writer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds underline styles, doublestrikethrough, smallcaps, allcaps, fgcolor, hidden, scale, spacing, kerning (not sure if the * 2 is correct, but I think it is), position, noproof, and bgcolor.
Does not implement:
shading or lang. Also not sure what "paragraph" is or whether it needs to be implemented.
May break tests for multiple reasons:
(these should be simple fixes, but I'm not sure which tests are broken)
Checklist: