RTF Writer: Border - Improved and Prepared for Future Implementations #2838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works with all border types now through setting the $type variable - section (page), paragraph, table, and cell. Prepared for future usage with header, footer, character, and row. Implements border style. Implements border space (for sections and paragraphs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RTF BorderWriter now detects the border type with the $type variable (each type of border has a different initial tag that must be set), implements setStyle and, for sections and paragraphs, setSpace.
RTF BorderWriter is prepared for future improvements to the RTF TableWriter, which currently doesn't use BorderWriter to write its borders.
RTF BorderWriter is prepared for future improvements to the elements FontStyle and RowStyle to allow borders there as well.
Documentation will be updated after this pull and pull #2831 are approved (as that pull created numerous documentation files, including borders.md).
Checklist: