Yet more minor improvements (#1030)

Author: Mark Baker

src/PhpSpreadsheet/Shared/Date.php

@@ -192,7 +192,7 @@ public static function excelToDateTimeObject($excelTimestamp, $timeZone = null)
         $interval = $days . ' days';
 
         return $baseDate->modify($interval)
-            ->setTime($hours, $minutes, $seconds);
+            ->setTime((int) $hours, (int) $minutes, (int) $seconds);
     }
 
     /**
@@ -244,12 +244,12 @@ public static function PHPToExcel($dateValue)
     public static function dateTimeToExcel(DateTimeInterface $dateValue)
     {
         return self::formattedPHPToExcel(
-            $dateValue->format('Y'),
-            $dateValue->format('m'),
-            $dateValue->format('d'),
-            $dateValue->format('H'),
-            $dateValue->format('i'),
-            $dateValue->format('s')
+            (int) $dateValue->format('Y'),
+            (int) $dateValue->format('m'),
+            (int) $dateValue->format('d'),
+            (int) $dateValue->format('H'),
+            (int) $dateValue->format('i'),
+            (int) $dateValue->format('s')
         );
     }
 

src/PhpSpreadsheet/Shared/Trend/ExponentialBestFit.php

@@ -113,7 +113,9 @@ private function exponentialRegression($yValues, $xValues, $const)
      */
     public function __construct($yValues, $xValues = [], $const = true)
     {
-        if (parent::__construct($yValues, $xValues) !== false) {
+        parent::__construct($yValues, $xValues);
+
+        if (!$this->error) {
             $this->exponentialRegression($yValues, $xValues, $const);
         }
     }

src/PhpSpreadsheet/Shared/Trend/LinearBestFit.php

@@ -72,7 +72,9 @@ private function linearRegression($yValues, $xValues, $const)
      */
     public function __construct($yValues, $xValues = [], $const = true)
     {
-        if (parent::__construct($yValues, $xValues) !== false) {
+        parent::__construct($yValues, $xValues);
+
+        if (!$this->error) {
             $this->linearRegression($yValues, $xValues, $const);
         }
     }

src/PhpSpreadsheet/Shared/Trend/LogarithmicBestFit.php

@@ -81,7 +81,9 @@ private function logarithmicRegression($yValues, $xValues, $const)
      */
     public function __construct($yValues, $xValues = [], $const = true)
     {
-        if (parent::__construct($yValues, $xValues) !== false) {
+        parent::__construct($yValues, $xValues);
+
+        if (!$this->error) {
             $this->logarithmicRegression($yValues, $xValues, $const);
         }
     }

src/PhpSpreadsheet/Shared/Trend/PolynomialBestFit.php

@@ -182,7 +182,9 @@ private function polynomialRegression($order, $yValues, $xValues)
      */
     public function __construct($order, $yValues, $xValues = [], $const = true)
     {
-        if (parent::__construct($yValues, $xValues) !== false) {
+        parent::__construct($yValues, $xValues);
+
+        if (!$this->error) {
             if ($order < $this->valueCount) {
                 $this->bestFitType .= '_' . $order;
                 $this->order = $order;

src/PhpSpreadsheet/Shared/Trend/PowerBestFit.php

@@ -105,7 +105,9 @@ private function powerRegression($yValues, $xValues, $const)
      */
     public function __construct($yValues, $xValues = [], $const = true)
     {
-        if (parent::__construct($yValues, $xValues) !== false) {
+        parent::__construct($yValues, $xValues);
+
+        if (!$this->error) {
             $this->powerRegression($yValues, $xValues, $const);
         }
     }