Merge pull request #4256 from oleibman/csvmacle

Get Us Closer to Csv Not Autodetect By Default

Author: oleibman

src/PhpSpreadsheet/Reader/Csv.php

@@ -84,10 +84,13 @@ class Csv extends BaseReader
      */
     private static $constructorCallback;
 
+    /** Will be changed to false in next major release */
+    public const DEFAULT_TEST_AUTODETECT = true;
+
     /**
      * Attempt autodetect line endings (deprecated after PHP8.1)?
      */
-    private bool $testAutodetect = true;
+    private bool $testAutodetect = self::DEFAULT_TEST_AUTODETECT;
 
     protected bool $castFormattedNumberToNumeric = false;
 

tests/PhpSpreadsheetTests/Reader/Csv/CsvLineEndingTest.php

@@ -12,6 +12,8 @@ class CsvLineEndingTest extends TestCase
 {
     private string $tempFile = '';
 
+    private static bool $alwaysFalse = false;
+
     protected function tearDown(): void
     {
         if ($this->tempFile !== '') {
@@ -30,6 +32,9 @@ public function testEndings(string $ending): void
         $data = ['123', '456', '789'];
         file_put_contents($filename, implode($ending, $data));
         $reader = new Csv();
+        if (Csv::DEFAULT_TEST_AUTODETECT === self::$alwaysFalse) {
+            $reader->setTestAutoDetect(true);
+        }
         $spreadsheet = $reader->load($filename);
         $sheet = $spreadsheet->getActiveSheet();
         self::assertEquals($data[0], $sheet->getCell('A1')->getValue());