Remove Reader/Writer deprecations

Author: MarkBaker

src/PhpSpreadsheet/Reader/Html.php

@@ -26,13 +26,6 @@ class Html extends BaseReader
      */
     const TEST_SAMPLE_SIZE = 2048;
 
-    /**
-     * Input encoding.
-     *
-     * @var string
-     */
-    protected $inputEncoding = 'ANSI';
-
     /**
      * Sheet index to read.
      *
@@ -210,38 +203,6 @@ protected function loadSpreadsheetFromFile(string $filename): Spreadsheet
         return $this->loadIntoExisting($filename, $spreadsheet);
     }
 
-    /**
-     * Set input encoding.
-     *
-     * @param string $inputEncoding Input encoding, eg: 'ANSI'
-     *
-     * @return $this
-     *
-     * @codeCoverageIgnore
-     *
-     * @deprecated no use is made of this property
-     */
-    public function setInputEncoding($inputEncoding)
-    {
-        $this->inputEncoding = $inputEncoding;
-
-        return $this;
-    }
-
-    /**
-     * Get input encoding.
-     *
-     * @return string
-     *
-     * @codeCoverageIgnore
-     *
-     * @deprecated no use is made of this property
-     */
-    public function getInputEncoding()
-    {
-        return $this->inputEncoding;
-    }
-
     //    Data Array used for testing only, should write to Spreadsheet object on completion of tests
 
     /** @var array */
@@ -255,7 +216,7 @@ public function getInputEncoding()
 
     protected function setTableStartColumn(string $column): string
     {
-        if ($this->tableLevel == 0) {
+        if ($this->tableLevel === 0) {
             $column = 'A';
         }
         ++$this->tableLevel;

src/PhpSpreadsheet/Reader/Slk.php

@@ -12,13 +12,6 @@
 
 class Slk extends BaseReader
 {
-    /**
-     * Input encoding.
-     *
-     * @var string
-     */
-    private $inputEncoding = 'ANSI';
-
     /**
      * Sheet index to read.
      *
@@ -97,38 +90,6 @@ private function canReadOrBust(string $filename): void
         $this->openFile($filename);
     }
 
-    /**
-     * Set input encoding.
-     *
-     * @deprecated no use is made of this property
-     *
-     * @param string $inputEncoding Input encoding, eg: 'ANSI'
-     *
-     * @return $this
-     *
-     * @codeCoverageIgnore
-     */
-    public function setInputEncoding($inputEncoding)
-    {
-        $this->inputEncoding = $inputEncoding;
-
-        return $this;
-    }
-
-    /**
-     * Get input encoding.
-     *
-     * @deprecated no use is made of this property
-     *
-     * @return string
-     *
-     * @codeCoverageIgnore
-     */
-    public function getInputEncoding()
-    {
-        return $this->inputEncoding;
-    }
-
     /**
      * Return worksheet info (Name, Last Column Letter, Last Column Index, Total Rows, Total Columns).
      *

src/PhpSpreadsheet/Writer/Html.php

@@ -63,13 +63,6 @@ class Html extends BaseWriter
      */
     private $useInlineCss = false;
 
-    /**
-     * Use embedded CSS?
-     *
-     * @var bool
-     */
-    private $useEmbeddedCSS = true;
-
     /**
      * Array of CSS styles.
      *
@@ -1596,38 +1589,6 @@ public function setUseInlineCss($useInlineCss)
         return $this;
     }
 
-    /**
-     * Get use embedded CSS?
-     *
-     * @return bool
-     *
-     * @codeCoverageIgnore
-     *
-     * @deprecated no longer used
-     */
-    public function getUseEmbeddedCSS()
-    {
-        return $this->useEmbeddedCSS;
-    }
-
-    /**
-     * Set use embedded CSS?
-     *
-     * @param bool $useEmbeddedCSS
-     *
-     * @return $this
-     *
-     * @codeCoverageIgnore
-     *
-     * @deprecated no longer used
-     */
-    public function setUseEmbeddedCSS($useEmbeddedCSS)
-    {
-        $this->useEmbeddedCSS = $useEmbeddedCSS;
-
-        return $this;
-    }
-
     /**
      * Add color to formatted string as inline style.
      *