Allow php-cs-fixer to Handle Implicit Backslashes

Author: oleibman

.php-cs-fixer.dist.php

@@ -204,7 +204,7 @@
         'static_lambda' => false, // Risky if we can't guarantee nobody use `bindTo()`
         'strict_comparison' => false, // No, too dangerous to change that
         'strict_param' => false, // No, too dangerous to change that
-        'string_implicit_backslashes' => false, // was escape_implicit_backslashes, too confusing
+        'string_implicit_backslashes' => ['single_quoted' => 'unescape', 'double_quoted' => 'escape', 'heredoc' => 'escape'], // was escape_implicit_backslashes
         'string_line_ending' => true,
         'switch_case_semicolon_to_colon' => true,
         'switch_case_space' => true,

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org).
 
 # TBD - 1.29.11
 
+### Changed
+
+- Allow php-cs-fixer to Handle Implicit Backslashes.
+
 ### Fixed
 
 - TEXT and TIMEVALUE functions. [Issue #4249](https://github.com/PHPOffice/PhpSpreadsheet/issues/4249) [PR #4352](https://github.com/PHPOffice/PhpSpreadsheet/pull/4352)

bin/findpolyfill.php

@@ -6,19 +6,19 @@ function findPolyfill(string $directory): int
     // See issue #4215 - code which should have erred in unit test
     // succeeded because a dev package required polyfills.
     $retCode = 0;
-    $polyfill80 = 'FILTER_VALIDATE_BOOL\\b'
+    $polyfill80 = 'FILTER_VALIDATE_BOOL\b'
         . '|fdiv[(]'
         . '|preg_last_error_msg[(]'
         . '|str_contains[(]'
         . '|str_starts_with[(]'
         . '|str_ends_with[(]'
         . '|get_debug_type[(]'
         . '|get_resource_id[(]';
-    $polyfill81 = 'MYSQLI_REFRESH_REPLICA\\b'
+    $polyfill81 = 'MYSQLI_REFRESH_REPLICA\b'
         . '|fdiv[(]'
         . '|array_is_list[(]'
         . '|enum_exists[(]';
-    $polyfill = '/\\b(?:'
+    $polyfill = '/\b(?:'
         . $polyfill80
         . '|'
         . $polyfill81

composer.json

@@ -12,6 +12,7 @@
         "spreadsheet"
     ],
     "config": {
+        "process-timeout": 600,
         "sort-packages": true,
         "allow-plugins": {
             "dealerdirect/phpcodesniffer-composer-installer": true

phpstan-conditional.php

@@ -49,28 +49,28 @@
     //];
     // Erroneous analysis by Phpstan before PHP8 - mb_strlen does not return false
     $config['parameters']['ignoreErrors'][] = [
-        'message' => '#^Method PhpOffice\\\\PhpSpreadsheet\\\\Shared\\\\StringHelper\\:\\:countCharacters\\(\\) should return int but returns int(<0, max>)?\\|false\\.$#',
+        'message' => '#^Method PhpOffice\\\PhpSpreadsheet\\\Shared\\\StringHelper\:\:countCharacters\(\) should return int but returns int(<0, max>)?\|false\.$#',
         'path' => __DIR__ . '/src/PhpSpreadsheet/Shared/StringHelper.php',
         'count' => 1,
     ];
     // New with Phpstan 1.9.2 for Php7 only
     $config['parameters']['ignoreErrors'][] = [
-        'message' => '#^Parameter \\#2 \\.\\.\\.\\$args of function array_merge expects array, array<int, mixed>\\|false given.$#',
+        'message' => '#^Parameter \#2 \.\.\.\$args of function array_merge expects array, array<int, mixed>\|false given.$#',
         'path' => __DIR__ . '/src/PhpSpreadsheet/Calculation/LookupRef/Sort.php',
         'count' => 1,
     ];
     $config['parameters']['ignoreErrors'][] = [
-        'message' => '#^Parameter \\#1 \\$input of function array_chunk expects array, array<int, float\\|int>\\|false given.$#',
+        'message' => '#^Parameter \#1 \$input of function array_chunk expects array, array<int, float\|int>\|false given.$#',
         'path' => __DIR__ . '/src/PhpSpreadsheet/Calculation/MathTrig/MatrixFunctions.php',
         'count' => 1,
     ];
     $config['parameters']['ignoreErrors'][] = [
-        'message' => '#^Parameter \\#2 \\$array of function array_map expects array, array<int, float|int>\\|false given.$#',
+        'message' => '#^Parameter \#2 \$array of function array_map expects array, array<int, float|int>\|false given.$#',
         'path' => __DIR__ . '/src/PhpSpreadsheet/Calculation/MathTrig/Random.php',
         'count' => 1,
     ];
     $config['parameters']['ignoreErrors'][] = [
-        'message' => '#^Parameter \\#2 \\.\\.\\.\\$args of function array_merge expects array, array<int, mixed>\\|false given.$#',
+        'message' => '#^Parameter \#2 \.\.\.\$args of function array_merge expects array, array<int, mixed>\|false given.$#',
         'path' => __DIR__ . '/src/PhpSpreadsheet/Calculation/TextData/Text.php',
         'count' => 1,
     ];

src/PhpSpreadsheet/Calculation/Calculation.php

@@ -46,7 +46,7 @@ class Calculation
     //    Defined Names: Named Range of cells, or Named Formulae
     const CALCULATION_REGEXP_DEFINEDNAME = '((([^\s,!&%^\/\*\+<>=-]*)|(\'(?:[^\']|\'[^!])+?\')|(\"(?:[^\"]|\"[^!])+?\"))!)?([_\p{L}][_\p{L}\p{N}\.]*)';
     // Structured Reference (Fully Qualified and Unqualified)
-    const CALCULATION_REGEXP_STRUCTURED_REFERENCE = '([\p{L}_\\\\][\p{L}\p{N}\._]+)?(\[(?:[^\d\]+-])?)';
+    const CALCULATION_REGEXP_STRUCTURED_REFERENCE = '([\p{L}_\\\][\p{L}\p{N}\._]+)?(\[(?:[^\d\]+-])?)';
     //    Error
     const CALCULATION_REGEXP_ERROR = '\#[A-Z][A-Z0_\/]*[!\?]?';
 

src/PhpSpreadsheet/Calculation/DateTimeExcel/DateValue.php

@@ -46,7 +46,7 @@ public static function fromString($dateValue)
         }
 
         // try to parse as date iff there is at least one digit
-        if (is_string($dateValue) && preg_match('/\\d/', $dateValue) !== 1) {
+        if (is_string($dateValue) && preg_match('/\d/', $dateValue) !== 1) {
             return ExcelError::VALUE();
         }
 

src/PhpSpreadsheet/Calculation/DateTimeExcel/TimeValue.php

@@ -57,7 +57,7 @@ public static function fromString($timeValue)
         }
 
         // try to parse as time iff there is at least one digit
-        if (is_string($timeValue) && preg_match('/\\d/', $timeValue) !== 1) {
+        if (is_string($timeValue) && preg_match('/\d/', $timeValue) !== 1) {
             return ExcelError::VALUE();
         }
 

src/PhpSpreadsheet/Calculation/Engine/Operands/StructuredReference.php

@@ -28,7 +28,7 @@ final class StructuredReference implements Operand
         self::ITEM_SPECIFIER_TOTALS,
     ];
 
-    private const TABLE_REFERENCE = '/([\p{L}_\\\\][\p{L}\p{N}\._]+)?(\[(?:[^\]\[]+|(?R))*+\])/miu';
+    private const TABLE_REFERENCE = '/([\p{L}_\\\][\p{L}\p{N}\._]+)?(\[(?:[^\]\[]+|(?R))*+\])/miu';
 
     private string $value;
 

src/PhpSpreadsheet/Calculation/FormulaParser.php

@@ -219,7 +219,7 @@ private function parseToTokens(): void
             // scientific notation check
             if (strpos(self::OPERATORS_SN, $this->formula[$index]) !== false) {
                 if (strlen($value) > 1) {
-                    if (preg_match('/^[1-9]{1}(\\.\\d+)?E{1}$/', $this->formula[$index]) != 0) {
+                    if (preg_match('/^[1-9]{1}(\.\d+)?E{1}$/', $this->formula[$index]) != 0) {
                         $value .= $this->formula[$index];
                         ++$index;