Merge pull request #2651 from PHPOffice/Issue-1971_Failing-to-correctly-escape-double-quotes-in-subformulae

Escape double quotes in a string value unless it's an empty string value

Author: Mark Baker

CHANGELOG.md

@@ -43,7 +43,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
   Note that this method is used when translating Excel functions between `en_us` and other locale languages, as well as when converting formulae between different spreadsheet formats (e.g. Ods to Excel).
 
   Nor is this a perfect solution, as there may still be issues when function calls have array arguments that themselves contain function calls; but it's still better than the current logic.
-
+- Fix for escaping double quotes within a formula [Issue #1971](https://github.com/PHPOffice/PhpSpreadsheet/issues/1971) [PR #2651](https://github.com/PHPOffice/PhpSpreadsheet/pull/2651)
 
 ## 1.22.0 - 2022-02-18
 

src/PhpSpreadsheet/Calculation/Functions.php

@@ -158,6 +158,10 @@ public static function ifCondition($condition)
             if (is_bool($condition)) {
                 return '=' . ($condition ? 'TRUE' : 'FALSE');
             } elseif (!is_numeric($condition)) {
+                if ($condition !== '""') { // Not an empty string
+                    // Escape any quotes in the string value
+                    $condition = preg_replace('/"/ui', '""', $condition);
+                }
                 $condition = Calculation::wrapResult(strtoupper($condition));
             }
 

tests/data/Calculation/Functions/IF_CONDITION.php

@@ -29,6 +29,18 @@
         '<"<A"',
         '<<A',
     ],
+    [
+        '="A"',
+        '=A',
+    ],
+    [
+        '="""A"""',
+        '="A"',
+    ],
+    [
+        '="""A""B"""',
+        '="A"B"',
+    ],
     [
         '<>"< PLEASE SELECT >"',
         '<>< Please Select >',