Skip to content

Commit 92389c7

Browse files
author
Mark Baker
authored
Ensure that the list of shared formulae is maintained while chunk-reading Xlsx Files (#1680)
* Ensure that the list of shared formulae is maintained while chunk-reading Xlsx files
1 parent 1cda811 commit 92389c7

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
2525

2626
### Fixed
2727

28-
- Nothing.
28+
- Ensure that the list of shared formulae is maintained when an xlsx file is chunked with readFilter[Issue #169](https://github.com/PHPOffice/PhpSpreadsheet/issues/1669).
2929

3030
## 1.15.0 - 2020-10-11
3131

src/PhpSpreadsheet/Reader/Xlsx.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -661,6 +661,9 @@ public function load($pFilename)
661661
$coordinates = Coordinate::coordinateFromString($r);
662662

663663
if (!$this->getReadFilter()->readCell($coordinates[0], (int) $coordinates[1], $docSheet->getTitle())) {
664+
if (isset($c->f)) {
665+
$this->castToFormula($c, $r, $cellDataType, $value, $calculatedValue, $sharedFormulas, 'castToError');
666+
}
664667
++$rowIndex;
665668

666669
continue;

0 commit comments

Comments
 (0)