Tweak to Spreadsheet Clone

Spreadsheet clone already copies Calculation instanceArrayReturnType property. It should also copy some other Calculation instance properties, namely suppressFormulaErrors, calculationCacheEnabled, and branchPruningEnabled.

Author: oleibman

src/PhpSpreadsheet/Calculation/Calculation.php

@@ -315,10 +315,12 @@ public function getCalculationCacheEnabled(): bool
     /**
      * Enable/disable calculation cache.
      */
-    public function setCalculationCacheEnabled(bool $calculationCacheEnabled): void
+    public function setCalculationCacheEnabled(bool $calculationCacheEnabled): self
     {
         $this->calculationCacheEnabled = $calculationCacheEnabled;
         $this->clearCalculationCache();
+
+        return $this;
     }
 
     /**
@@ -366,13 +368,17 @@ public function renameCalculationCacheForWorksheet(string $fromWorksheetName, st
         }
     }
 
-    /**
-     * Enable/disable calculation cache.
-     */
-    public function setBranchPruningEnabled(mixed $enabled): void
+    public function getBranchPruningEnabled(): bool
+    {
+        return $this->branchPruningEnabled;
+    }
+
+    public function setBranchPruningEnabled(mixed $enabled): self
     {
         $this->branchPruningEnabled = $enabled;
         $this->branchPruner = new BranchPruner($this->branchPruningEnabled);
+
+        return $this;
     }
 
     public function enableBranchPruning(): void
@@ -2687,9 +2693,11 @@ private function evaluateDefinedName(Cell $cell, DefinedName $namedRange, Worksh
         return $result;
     }
 
-    public function setSuppressFormulaErrors(bool $suppressFormulaErrors): void
+    public function setSuppressFormulaErrors(bool $suppressFormulaErrors): self
     {
         $this->suppressFormulaErrors = $suppressFormulaErrors;
+
+        return $this;
     }
 
     public function getSuppressFormulaErrors(): bool
@@ -2732,4 +2740,9 @@ private static function swapOperands(Stack $stack, string $opCharacter): bool
 
         return $retVal;
     }
+
+    public function getSpreadsheet(): ?Spreadsheet
+    {
+        return $this->spreadsheet;
+    }
 }

src/PhpSpreadsheet/Spreadsheet.php

@@ -1079,6 +1079,15 @@ public function __clone()
         $this->calculationEngine = new Calculation($this);
         if ($oldCalc !== null) {
             $this->calculationEngine
+                ->setSuppressFormulaErrors(
+                    $oldCalc->getSuppressFormulaErrors()
+                )
+                ->setCalculationCacheEnabled(
+                    $oldCalc->getCalculationCacheEnabled()
+                )
+                ->setBranchPruningEnabled(
+                    $oldCalc->getBranchPruningEnabled()
+                )
                 ->setInstanceArrayReturnType(
                     $oldCalc->getInstanceArrayReturnType()
                 );

tests/PhpSpreadsheetTests/SpreadsheetCopyCloneTest.php

@@ -49,6 +49,8 @@ public function testCopyClone(string $type): void
         } else {
             $this->spreadsheet2 = clone $this->spreadsheet;
         }
+        self::assertSame($this->spreadsheet, $this->spreadsheet->getCalculationEngine()->getSpreadsheet());
+        self::assertSame($this->spreadsheet2, $this->spreadsheet2->getCalculationEngine()->getSpreadsheet());
         self::assertSame('A3', $sheet->getSelectedCells());
         $copysheet = $this->spreadsheet2->getActiveSheet();
         self::assertSame('A3', $copysheet->getSelectedCells());
@@ -112,4 +114,37 @@ public static function providerCopyClone(): array
             ['clone'],
         ];
     }
+
+    public static function providerCopyClone2(): array
+    {
+        return [
+            ['copy', true, false, true, 'array'],
+            ['clone', true, false, true, 'array'],
+            ['copy', false, true, false, 'value'],
+            ['clone', false, true, false, 'value'],
+            ['copy', false, true, true, 'error'],
+            ['clone', false, true, true, 'error'],
+        ];
+    }
+
+    #[DataProvider('providerCopyClone2')]
+    public function testCopyClone2(string $type, bool $suppress, bool $cache, bool $pruning, string $return): void
+    {
+        $this->spreadsheet = new Spreadsheet();
+        $calc = $this->spreadsheet->getCalculationEngine();
+        $calc->setSuppressFormulaErrors($suppress);
+        $calc->setCalculationCacheEnabled($cache);
+        $calc->setBranchPruningEnabled($pruning);
+        $calc->setInstanceArrayReturnType($return);
+        if ($type === 'copy') {
+            $this->spreadsheet2 = $this->spreadsheet->copy();
+        } else {
+            $this->spreadsheet2 = clone $this->spreadsheet;
+        }
+        $calc2 = $this->spreadsheet2->getCalculationEngine();
+        self::assertSame($suppress, $calc2->getSuppressFormulaErrors());
+        self::assertSame($cache, $calc2->getCalculationCacheEnabled());
+        self::assertSame($pruning, $calc2->getBranchPruningEnabled());
+        self::assertSame($return, $calc2->getInstanceArrayReturnType());
+    }
 }