PHP 8.5: Prevent deprecation notices for imagedestroy

TobiasBg · web-flow · commit 9baabd2a0bff · 2025-09-01T16:50:53.000+02:00
`imagedestroy` is deprecated in PHP 8.5+, and hasn't been doing anything since PHP 8.0. To prevent deprecation warnings it should therefore be called on older versions of PHP only. See https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_no-op_functions_from_the_resource_to_object_conversion.
diff --git a/src/PhpSpreadsheet/Worksheet/MemoryDrawing.php b/src/PhpSpreadsheet/Worksheet/MemoryDrawing.php
@@ -65,7 +65,9 @@ public function __construct()
     public function __destruct()
     {
         if ($this->imageResource) {
-            @imagedestroy($this->imageResource);
+            if (\PHP_VERSION_ID < 80000) {
+                @imagedestroy($this->imageResource);
+            }
             $this->imageResource = null;
         }
         $this->worksheet = null;

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,9 @@ public function __construct()`
`65`	`65`	`public function __destruct()`
`66`	`66`	`{`
`67`	`67`	`if ($this->imageResource) {`
`68`		`- @imagedestroy($this->imageResource);`
	`68`	`+ if (\PHP_VERSION_ID < 80000) {`
	`69`	`+ @imagedestroy($this->imageResource);`
	`70`	`+ }`
`69`	`71`	`$this->imageResource = null;`
`70`	`72`	`}`
`71`	`73`	`$this->worksheet = null;`