Set precision for Database function unit tests, for RowColumnReference and Dimension Helper unit tests (#2604)

Mark Baker · web-flow · commit 9c473682bc52 · 2022-02-18T21:37:26.000+01:00
diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DAverageTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DAverageTest.php
@@ -24,7 +24,7 @@ protected function setUp(): void
     public function testDAverage($expectedResult, $database, $field, $criteria): void
     {
         $result = Database::DAVERAGE($database, $field, $criteria);
-        self::assertSame($expectedResult, $result);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
     }
 
     private function database1(): array
diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DCountATest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DCountATest.php
@@ -24,7 +24,7 @@ protected function setUp(): void
     public function testDCountA($expectedResult, $database, $field, $criteria): void
     {
         $result = Database::DCOUNTA($database, $field, $criteria);
-        self::assertSame($expectedResult, $result);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
     }
 
     private function database1(): array
diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DCountTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DCountTest.php
@@ -24,7 +24,7 @@ protected function setUp(): void
     public function testDCount($expectedResult, $database, $field, $criteria): void
     {
         $result = Database::DCOUNT($database, $field, $criteria);
-        self::assertSame($expectedResult, $result);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
     }
 
     private function database1(): array
diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DGetTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DGetTest.php
@@ -24,7 +24,7 @@ protected function setUp(): void
     public function testDGet($expectedResult, $database, $field, $criteria): void
     {
         $result = Database::DGET($database, $field, $criteria);
-        self::assertSame($expectedResult, $result);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
     }
 
     private function database1(): array
diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DMaxTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DMaxTest.php
@@ -24,7 +24,7 @@ protected function setUp(): void
     public function testDMax($expectedResult, $database, $field, $criteria): void
     {
         $result = Database::DMAX($database, $field, $criteria);
-        self::assertSame($expectedResult, $result);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
     }
 
     private function database1(): array
diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DMinTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DMinTest.php
@@ -24,7 +24,7 @@ protected function setUp(): void
     public function testDMin($expectedResult, $database, $field, $criteria): void
     {
         $result = Database::DMIN($database, $field, $criteria);
-        self::assertSame($expectedResult, $result);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
     }
 
     private function database1(): array
diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DProductTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DProductTest.php
@@ -25,7 +25,7 @@ protected function setUp(): void
     public function testDProduct($expectedResult, $database, $field, $criteria): void
     {
         $result = Database::DPRODUCT($database, $field, $criteria);
-        self::assertSame($expectedResult, $result);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
     }
 
     private function database1(): array
diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DStDevPTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DStDevPTest.php
@@ -24,7 +24,7 @@ protected function setUp(): void
     public function testDStDevP($expectedResult, $database, $field, $criteria): void
     {
         $result = Database::DSTDEVP($database, $field, $criteria);
-        self::assertSame($expectedResult, $result);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
     }
 
     private function database1(): array
diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DStDevTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DStDevTest.php
@@ -24,7 +24,7 @@ protected function setUp(): void
     public function testDStDev($expectedResult, $database, $field, $criteria): void
     {
         $result = Database::DSTDEV($database, $field, $criteria);
-        self::assertSame($expectedResult, $result);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
     }
 
     private function database1(): array
diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DSumTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DSumTest.php
@@ -24,7 +24,7 @@ protected function setUp(): void
     public function testDSum($expectedResult, $database, $field, $criteria): void
     {
         $result = Database::DSUM($database, $field, $criteria);
-        self::assertSame($expectedResult, $result);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
     }
 
     private function database1(): array
diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DVarPTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DVarPTest.php
@@ -24,7 +24,7 @@ protected function setUp(): void
     public function testDVarP($expectedResult, $database, $field, $criteria): void
     {
         $result = Database::DVARP($database, $field, $criteria);
-        self::assertSame($expectedResult, $result);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
     }
 
     private function database1(): array
diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DVarTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DVarTest.php
@@ -24,7 +24,7 @@ protected function setUp(): void
     public function testDVar($expectedResult, $database, $field, $criteria): void
     {
         $result = Database::DVAR($database, $field, $criteria);
-        self::assertSame($expectedResult, $result);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
     }
 
     private function database1(): array
diff --git a/tests/PhpSpreadsheetTests/Calculation/RowColumnReferenceTest.php b/tests/PhpSpreadsheetTests/Calculation/RowColumnReferenceTest.php
@@ -46,7 +46,7 @@ public function testCurrentWorksheet(string $formula, float $expectedResult): vo
         $worksheet->setCellValue('A1', $formula);
 
         $result = $worksheet->getCell('A1')->getCalculatedValue();
-        self::assertSame($expectedResult, $result);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
     }
 
     public function providerCurrentWorksheetFormulae(): array
diff --git a/tests/PhpSpreadsheetTests/Helper/DimensionTest.php b/tests/PhpSpreadsheetTests/Helper/DimensionTest.php
@@ -23,7 +23,7 @@ public function testCreateDimension(float $expectedResult, string $dimension): v
     public function testConvertDimension(float $expectedResult, string $dimension, string $unitOfMeasure): void
     {
         $result = (new Dimension($dimension))->toUnit($unitOfMeasure);
-        self::assertSame($expectedResult, $result);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
     }
 
     public function testConvertDimensionInvalidUoM(): void

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ protected function setUp(): void`
`24`	`24`	`public function testDAverage($expectedResult, $database, $field, $criteria): void`
`25`	`25`	`{`
`26`	`26`	`$result = Database::DAVERAGE($database, $field, $criteria);`
`27`		`- self::assertSame($expectedResult, $result);`
	`27`	`+ self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`private function database1(): array`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ protected function setUp(): void`
`25`	`25`	`public function testDProduct($expectedResult, $database, $field, $criteria): void`
`26`	`26`	`{`
`27`	`27`	`$result = Database::DPRODUCT($database, $field, $criteria);`
`28`		`- self::assertSame($expectedResult, $result);`
	`28`	`+ self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`private function database1(): array`