Skip to content

Commit 9d36e44

Browse files
authored
Disable URLImageTest (#2843)
This test has always been problematic in that it depends on an external site not under the control of PhpSpreadsheet, and can therefore break at any time. As it has done this morning. Disable it until a better test is available.
1 parent b895720 commit 9d36e44

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

tests/PhpSpreadsheetTests/Reader/Xlsx/URLImageTest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,12 @@ class URLImageTest extends TestCase
1111
{
1212
public function testURLImageSource(): void
1313
{
14-
if (getenv('SKIP_URL_IMAGE_TEST') === '1') {
15-
self::markTestSkipped('Skipped due to setting of environment variable');
14+
if (getenv('RUN_URL_IMAGE_TEST') !== '1') {
15+
self::markTestSkipped('Skipped due to no longer bein able to access external URL');
1616
}
17+
//if (getenv('SKIP_URL_IMAGE_TEST') === '1') {
18+
// self::markTestSkipped('Skipped due to setting of environment variable');
19+
//}
1720
$filename = realpath(__DIR__ . '/../../../data/Reader/XLSX/urlImage.xlsx');
1821
self::assertNotFalse($filename);
1922
$reader = IOFactory::createReader('Xlsx');

0 commit comments

Comments
 (0)