Skip to content

Commit b7d48e6

Browse files
committed
More Minor Tweaks
1 parent eec2357 commit b7d48e6

File tree

3 files changed

+42
-2
lines changed

3 files changed

+42
-2
lines changed

tests/PhpSpreadsheetTests/Helper/DimensionTest.php

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,24 +6,40 @@
66

77
use PhpOffice\PhpSpreadsheet\Exception;
88
use PhpOffice\PhpSpreadsheet\Helper\Dimension;
9+
use PhpOffice\PhpSpreadsheet\Helper\Size;
10+
use PHPUnit\Framework\Attributes\DataProvider;
911
use PHPUnit\Framework\TestCase;
1012

1113
class DimensionTest extends TestCase
1214
{
13-
#[\PHPUnit\Framework\Attributes\DataProvider('providerCellWidth')]
15+
#[DataProvider('providerCellWidth')]
1416
public function testCreateDimension(float $expectedResult, string $dimension): void
1517
{
1618
$result = (new Dimension($dimension))->width();
1719
self::assertSame($expectedResult, $result);
1820
}
1921

20-
#[\PHPUnit\Framework\Attributes\DataProvider('providerConvertUoM')]
22+
#[DataProvider('providerConvertUoM')]
2123
public function testConvertDimension(float $expectedResult, string $dimension, string $unitOfMeasure): void
2224
{
2325
$result = (new Dimension($dimension))->toUnit($unitOfMeasure);
2426
self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
2527
}
2628

29+
public function testSizeAndUnit(): void
30+
{
31+
$size = new Size('10px');
32+
self::assertTrue($size->valid());
33+
self::assertSame('10', $size->size());
34+
self::assertSame('px', $size->unit());
35+
$size = new Size('9.3');
36+
self::assertTrue($size->valid());
37+
self::assertSame('9.3', $size->size());
38+
self::assertSame('pt', $size->unit());
39+
$size = new Size('8whatever');
40+
self::assertFalse($size->valid());
41+
}
42+
2743
public function testConvertDimensionInvalidUoM(): void
2844
{
2945
$this->expectException(Exception::class);

tests/PhpSpreadsheetTests/Helper/SampleCoverageTest.php

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,19 @@ public function testDirectoryFail(): void
3535
->willReturn(false);
3636
$helper->getFilename('a.xlsx');
3737
}
38+
39+
public function testTitles(): void
40+
{
41+
$helper = new Sample();
42+
ob_start();
43+
$helper->titles('Category', 'FunctionName');
44+
$output = (string) ob_get_clean();
45+
$output = str_replace("\r", '', $output);
46+
self::assertStringContainsString("Function: FunctionName()\n", $output);
47+
ob_start();
48+
$helper->titles('Category', 'FunctionName', 'Description');
49+
$output = (string) ob_get_clean();
50+
$output = str_replace("\r", '', $output);
51+
self::assertStringContainsString("Function: FunctionName() - Description.\n", $output);
52+
}
3853
}

tests/PhpSpreadsheetTests/Style/FontTest.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,4 +108,13 @@ public function testUnderlineHash(): void
108108
$font2bHash = $font2->getHashCode();
109109
self::assertNotEquals($font1->getHashCode(), $font2bHash);
110110
}
111+
112+
public function testAutoColorSupervisor(): void
113+
{
114+
$spreadsheet = new Spreadsheet();
115+
$sheet = $spreadsheet->getActiveSheet();
116+
$sheet->getStyle('A1')->getFont()->setAutoColor(true);
117+
self::assertTrue($sheet->getStyle('A1')->getFont()->getAutoColor());
118+
$spreadsheet->disconnectWorksheets();
119+
}
111120
}

0 commit comments

Comments
 (0)