Skip to content

Commit db89fe2

Browse files
committed
Simplify Test Bootstrap
1 parent 4545ecf commit db89fe2

File tree

2 files changed

+5
-14
lines changed

2 files changed

+5
-14
lines changed

tests/PhpSpreadsheetTests/Chart/ChartsDynamicTitleTest.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@
1717
use PhpOffice\PhpSpreadsheet\Writer\Xlsx as XlsxWriter;
1818
use PhpOffice\PhpSpreadsheetTests\Functional\AbstractFunctional;
1919

20+
/**
21+
* Seems to need to be separate for Php8.4 PhpUnit9 combination.
22+
*
23+
* @runTestsInSeparateProcesses
24+
*/
2025
class ChartsDynamicTitleTest extends AbstractFunctional
2126
{
2227
protected function tearDown(): void

tests/bootstrap.php

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,20 +25,6 @@ function phpunit10ErrorHandler(int $errno, string $errstr, string $filename, int
2525
return true; // message suppressed - stop error handling
2626
}
2727

28-
// This code applies only when running release210 with Php8.4.
29-
// I don't get it at all. I think mitoteam is the victim of circumstance.
30-
// We need to run PhpUnit 9 because we need to support Php8.0.
31-
// We are at the highest release of PhpUnit9,
32-
// but it refers to E_STRICT,
33-
// which is deprecated in 8.4.
34-
if (
35-
str_contains($errstr, 'Constant ')
36-
&& str_contains($errstr, ' already defined')
37-
&& str_contains($filename, 'mitoteam')
38-
) {
39-
return true;
40-
}
41-
4228
if (!method_exists(PHPUnit\Framework\TestCase::class, 'setOutputCallback')) {
4329
throw new Exception("$errstr $filename $lineno");
4430
}

0 commit comments

Comments
 (0)