Skip to content

Commit ee700f7

Browse files
mosaxivPowerKiKi
authored andcommitted
change array_push() to $array[] (#254)
http://php.net/manual/en/function.array-push.php#refsect1-function.array-push-description > Note: If you use array_push() to add one element to the array it's better to use $array[] = because in that way there is no overhead of calling a function.
1 parent b3e6538 commit ee700f7

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

docs/topics/recipes.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -856,8 +856,8 @@ $conditional2->getStyle()->getFont()->getColor()->setARGB(\PhpOffice\PhpSpreadsh
856856
$conditional2->getStyle()->getFont()->setBold(true);
857857

858858
$conditionalStyles = $spreadsheet->getActiveSheet()->getStyle('B2')->getConditionalStyles();
859-
array_push($conditionalStyles, $conditional1);
860-
array_push($conditionalStyles, $conditional2);
859+
$conditionalStyles[] = $conditional1;
860+
$conditionalStyles[] = $conditional2;
861861

862862
$spreadsheet->getActiveSheet()->getStyle('B2')->setConditionalStyles($conditionalStyles);
863863
```

samples/Basic/08_Conditional_formatting.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,9 @@
7979
$conditional3->getStyle()->getNumberFormat()->setFormatCode(NumberFormat::FORMAT_CURRENCY_EUR_SIMPLE);
8080

8181
$conditionalStyles = $spreadsheet->getActiveSheet()->getStyle('B2')->getConditionalStyles();
82-
array_push($conditionalStyles, $conditional1);
83-
array_push($conditionalStyles, $conditional2);
84-
array_push($conditionalStyles, $conditional3);
82+
$conditionalStyles[] = $conditional1;
83+
$conditionalStyles[] = $conditional2;
84+
$conditionalStyles[] = $conditional3;
8585
$spreadsheet->getActiveSheet()->getStyle('B2')->setConditionalStyles($conditionalStyles);
8686

8787
// duplicate the conditional styles across a range of cells

samples/Basic/08_Conditional_formatting_2.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@
5555
$conditional3->getStyle()->getFont()->getColor()->setARGB(Color::COLOR_GREEN);
5656

5757
$conditionalStyles = $spreadsheet->getActiveSheet()->getStyle('A1')->getConditionalStyles();
58-
array_push($conditionalStyles, $conditional1);
59-
array_push($conditionalStyles, $conditional3);
58+
$conditionalStyles[] = $conditional1;
59+
$conditionalStyles[] = $conditional3;
6060
$spreadsheet->getActiveSheet()->getStyle('A1')->setConditionalStyles($conditionalStyles);
6161

6262
// duplicate the conditional styles across a range of cells

tests/PhpSpreadsheetTests/Writer/Xls/WorkbookTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public function providerAddColor()
8686

8787
// Add new color after all existing color
8888
$colorsAddTwo = array_map([$this, 'paletteToColor'], $palette);
89-
array_push($colorsAddTwo, $this->paletteToColor($newColor1));
89+
$colorsAddTwo[] = $this->paletteToColor($newColor1);
9090
$paletteTestSix = $palette;
9191

9292
// Add one existing color

0 commit comments

Comments
 (0)