Skip to content

Commit f7cf378

Browse files
authored
Merge pull request #3957 from oleibman/htmlcomments
Html Writer Comments - Breaking Change
2 parents e63e8a9 + f20688c commit f7cf378

File tree

6 files changed

+344
-691
lines changed

6 files changed

+344
-691
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org).
77

88
## Unreleased - TBD
99

10+
### BREAKING CHANGE
11+
12+
- Writing of cell comments to Html will now sanitize all Html tags within the comment, so the tags will be rendered as plaintext and have no other effects when rendered. Styling can be achieved by using the Font property of of the TextRuns which make up the comment, as is already the cases for Xlsx. [PR #3957](https://github.com/PHPOffice/PhpSpreadsheet/pull/3957)
13+
1014
### Added
1115

1216
- Default Style Alignment Property (workaround for bug in non-Excel spreadsheet apps) [Issue #3918](https://github.com/PHPOffice/PhpSpreadsheet/issues/3918) [PR #3924](https://github.com/PHPOffice/PhpSpreadsheet/pull/3924)

composer.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,7 @@
8484
"markbaker/matrix": "^3.0",
8585
"psr/http-client": "^1.0",
8686
"psr/http-factory": "^1.0",
87-
"psr/simple-cache": "^1.0 || ^2.0 || ^3.0",
88-
"voku/anti-xss": "^4.1"
87+
"psr/simple-cache": "^1.0 || ^2.0 || ^3.0"
8988
},
9089
"require-dev": {
9190
"dealerdirect/phpcodesniffer-composer-installer": "dev-main",

0 commit comments

Comments
 (0)