Upgrade Phpstan

Too many problems with Dependabot update.

Author: oleibman

composer.lock

@@ -720,7 +720,7 @@ public static function colourNameLookup(string $colorName): string
 
     protected function startFontTag(DOMElement $tag): void
     {
-        $attrs = $tag->attributes;
+        $attrs = $tag->attributes ?? [];
         /** @var DOMAttr $attribute */
         foreach ($attrs as $attribute) {
             $attributeName = strtolower($attribute->name);

src/PhpSpreadsheet/Helper/Html.php

@@ -227,7 +227,8 @@ private static function getReaderTypeFromExtension(string $filename): ?string
      */
     public static function registerWriter(string $writerType, string $writerClass): void
     {
-        if (!is_a($writerClass, IWriter::class, true)) {
+        // We want phpstan to validate caller, but still need this test
+        if (!is_a($writerClass, IWriter::class, true)) { //* @phpstan-ignore-line
             throw new Writer\Exception('Registered writers must implement ' . IWriter::class);
         }
 
@@ -241,7 +242,8 @@ public static function registerWriter(string $writerType, string $writerClass):
      */
     public static function registerReader(string $readerType, string $readerClass): void
     {
-        if (!is_a($readerClass, IReader::class, true)) {
+        // We want phpstan to validate caller, but still need this test
+        if (!is_a($readerClass, IReader::class, true)) { //* @phpstan-ignore-line
             throw new Reader\Exception('Registered readers must implement ' . IReader::class);
         }
 

src/PhpSpreadsheet/IOFactory.php

@@ -338,7 +338,7 @@ private function processDomElementBody(Worksheet $sheet, int &$row, string &$col
     {
         $attributeArray = [];
         /** @var DOMAttr $attribute */
-        foreach ($child->attributes as $attribute) {
+        foreach (($child->attributes ?? []) as $attribute) {
             $attributeArray[$attribute->name] = $attribute->value;
         }
 

src/PhpSpreadsheet/Reader/Html.php

@@ -57,7 +57,8 @@ public static function getLocale(): string
      */
     public static function setChartRenderer(string $rendererClassName): void
     {
-        if (!is_a($rendererClassName, IRenderer::class, true)) {
+        // We want phpstan to validate caller, but still need this test
+        if (!is_a($rendererClassName, IRenderer::class, true)) { //* @phpstan-ignore-line
             throw new Exception('Chart renderer must implement ' . IRenderer::class);
         }
 

src/PhpSpreadsheet/Settings.php

@@ -66,7 +66,7 @@ public function stream_open(string $path, string $mode, int $options, ?string &$
             return false;
         }
         $this->ole = $GLOBALS['_OLE_INSTANCES'][$this->params['oleInstanceId']]; //* @phpstan-ignore-line
-        if (!($this->ole instanceof OLE)) {
+        if (!($this->ole instanceof OLE)) { //* @phpstan-ignore-line
             throw new Exception('class is not OLE');
         }
 

src/PhpSpreadsheet/Shared/OLE/ChainedBlockStream.php

@@ -317,8 +317,7 @@ public static function sanitizeUTF8(string $textValue): string
         $textValue = str_replace(["\xef\xbf\xbe", "\xef\xbf\xbf"], "\xef\xbf\xbd", $textValue);
         $subst = mb_substitute_character(); // default is question mark
         mb_substitute_character(65533); // Unicode substitution character
-        // Phpstan does not think this can return false.
-        $returnValue = mb_convert_encoding($textValue, 'UTF-8', 'UTF-8');
+        $returnValue = (string) mb_convert_encoding($textValue, 'UTF-8', 'UTF-8');
         mb_substitute_character($subst);
 
         return $returnValue;
@@ -411,7 +410,7 @@ public static function convertEncoding(string $textValue, string $to, string $fr
             }
         }
 
-        return mb_convert_encoding($textValue, $to, $from);
+        return (string) mb_convert_encoding($textValue, $to, $from);
     }
 
     /**

src/PhpSpreadsheet/Shared/StringHelper.php

@@ -280,7 +280,7 @@ public static function padValue(string $value, string $baseFormat): string
         $preDecimal = $postDecimal = '';
         $pregArray = preg_split('/\.(?=(?:[^"]*"[^"]*")*[^"]*\Z)/miu', $baseFormat . '.?');
         if (is_array($pregArray)) {
-            $preDecimal = $pregArray[0] ?? '';
+            $preDecimal = $pregArray[0];
             $postDecimal = $pregArray[1] ?? '';
         }
 

src/PhpSpreadsheet/Style/NumberFormat/NumberFormatter.php

@@ -325,7 +325,7 @@ private function writeLine($fileHandle, array $values): void
 
         // Write to file
         if ($this->outputEncoding != '') {
-            $line = mb_convert_encoding($line, $this->outputEncoding);
+            $line = (string) mb_convert_encoding($line, $this->outputEncoding);
         }
         fwrite($fileHandle, $line);
     }

src/PhpSpreadsheet/Writer/Csv.php

@@ -4,6 +4,7 @@
 
 namespace PhpOffice\PhpSpreadsheetTests\Calculation\Functions\DateTime;
 
+use DateTimeInterface;
 use PhpOffice\PhpSpreadsheet\Calculation\Calculation;
 use PhpOffice\PhpSpreadsheet\Calculation\DateTimeExcel\Date;
 use PhpOffice\PhpSpreadsheet\Calculation\Exception as CalculationException;
@@ -119,9 +120,8 @@ public function testDATEtoDateTimeObject(): void
 
         $result = Date::fromYMD(2012, 1, 31);
         //    Must return an object...
-        self::assertIsObject($result);
         //    ... of the correct type
-        self::assertTrue(is_a($result, 'DateTimeInterface'));
+        self::assertInstanceOf(DateTimeInterface::class, $result);
         //    ... with the correct value
         self::assertEquals($result->format('d-M-Y'), '31-Jan-2012');
     }