Skip to content

Commit f9d941a

Browse files
author
MarkBaker
committed
Tweaks to HTML generation, accessing cells directly from the collection
1 parent 0dc1e9b commit f9d941a

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

src/PhpSpreadsheet/Writer/Html.php

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -477,12 +477,8 @@ public function generateSheetData()
477477
$column = $minCol;
478478
while ($column <= $maxCol) {
479479
// Cell exists?
480-
if ($sheet->cellExistsByColumnAndRow($column, $row)) {
481-
$rowData[$column] = Coordinate::stringFromColumnIndex($column) . $row;
482-
} else {
483-
$rowData[$column] = '';
484-
}
485-
++$column;
480+
$cellAddress = Coordinate::stringFromColumnIndex($column) . $row;
481+
$rowData[$column++] = ($sheet->getCellCollection()->has($cellAddress)) ? $cellAddress : '';
486482
}
487483
$html .= $this->generateRow($sheet, $rowData, $row - 1, $cellType);
488484
}
@@ -1232,7 +1228,7 @@ private function generateRowStart(Worksheet $worksheet, $sheetIndex, $row)
12321228

12331229
private function generateRowCellCss(Worksheet $worksheet, $cellAddress, $row, $columnNumber)
12341230
{
1235-
$cell = ($cellAddress > '') ? $worksheet->getCell($cellAddress) : '';
1231+
$cell = ($cellAddress > '') ? $worksheet->getCellCollection()->get($cellAddress) : '';
12361232
$coordinate = Coordinate::stringFromColumnIndex($columnNumber + 1) . ($row + 1);
12371233
if (!$this->useInlineCss) {
12381234
$cssClass = 'column' . $columnNumber;

0 commit comments

Comments
 (0)