Merge pull request #4625 from TobiasBg/patch-1

oleibman · web-flow · commit fb51c3d964f7 · 2025-09-01T18:21:23.000Z
PHP 8.5: Prevent deprecation notices for imagedestroy
diff --git a/src/PhpSpreadsheet/Worksheet/MemoryDrawing.php b/src/PhpSpreadsheet/Worksheet/MemoryDrawing.php
@@ -64,10 +64,7 @@ public function __construct()
 
     public function __destruct()
     {
-        if ($this->imageResource) {
-            @imagedestroy($this->imageResource);
-            $this->imageResource = null;
-        }
+        $this->imageResource = null;
         $this->worksheet = null;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -64,10 +64,7 @@ public function __construct()`
`64`	`64`
`65`	`65`	`public function __destruct()`
`66`	`66`	`{`
`67`		`- if ($this->imageResource) {`
`68`		`- @imagedestroy($this->imageResource);`
`69`		`- $this->imageResource = null;`
`70`		`- }`
	`67`	`+ $this->imageResource = null;`
`71`	`68`	`$this->worksheet = null;`
`72`	`69`	`}`
`73`	`70`