Fixed #855 (v8)

Author: Geolim4

lib/Phpfastcache/Cluster/ClusterPoolAbstract.php

@@ -162,9 +162,8 @@ protected function getStandardizedItem(ExtendedCacheItemInterface $item, Extende
             if ($driverPool === $this) {
                 /** @var ExtendedCacheItemInterface $itemPool */
                 $itemClass = $driverPool->getClassNamespace() . '\\' . 'Item';
-                $itemPool = new $itemClass($this, $item->getKey());
-                $itemPool->setEventManager($this->getEventManager())
-                    ->set($item->get())
+                $itemPool = new $itemClass($this, $item->getKey(), $this->getEventManager());
+                $itemPool->set($item->get())
                     ->setHit($item->isHit())
                     ->setTags($item->getTags())
                     ->expiresAt($item->getExpirationDate())

lib/Phpfastcache/Cluster/Drivers/FullReplication/FullReplicationCluster.php

@@ -75,7 +75,12 @@ public function getItem($key)
             }
         }
 
-        return $this->getStandardizedItem($item ?? new Item($this, $key), $this);
+        if ($item === null) {
+            $item = new Item($this, $key, $this->getEventManager());
+            $item->expiresAfter(abs($this->getConfig()->getDefaultTtl()));
+        }
+
+        return $this->getStandardizedItem($item, $this);
     }
 
     /**

lib/Phpfastcache/Cluster/Drivers/MasterSlaveReplication/MasterSlaveReplicationCluster.php

@@ -62,7 +62,7 @@ public function getItem($key)
                 static function (ExtendedCacheItemPoolInterface $pool) use ($key) {
                     return $pool->getItem($key);
                 }
-            ) ?? new Item($this, $key),
+            ) ?? (new Item($this, $key, $this->getEventManager()))->expiresAfter(abs($this->getConfig()->getDefaultTtl())),
             $this
         );
     }

lib/Phpfastcache/Cluster/Drivers/SemiReplication/SemiReplicationCluster.php

@@ -54,7 +54,12 @@ public function getItem($key)
             throw new PhpfastcacheReplicationException('Every pools thrown an exception');
         }
 
-        return $this->getStandardizedItem($item ?? new Item($this, $key), $this);
+        if ($item === null) {
+            $item = new Item($this, $key, $this->getEventManager());
+            $item->expiresAfter(abs($this->getConfig()->getDefaultTtl()));
+        }
+
+        return $this->getStandardizedItem($item, $this);
     }
 
     /**

lib/Phpfastcache/Cluster/ItemAbstract.php

@@ -18,6 +18,7 @@
 
 use Phpfastcache\Core\Item\{ExtendedCacheItemInterface, ItemBaseTrait};
 use Phpfastcache\Core\Pool\ExtendedCacheItemPoolInterface;
+use Phpfastcache\Event\EventManagerInterface;
 use Phpfastcache\Exceptions\{PhpfastcacheInvalidArgumentException};
 
 /**
@@ -30,6 +31,12 @@ abstract class ItemAbstract implements ExtendedCacheItemInterface
         ItemBaseTrait::__construct as __BaseConstruct;
     }
 
+    public function __construct(ExtendedCacheItemPoolInterface $driver, $key, EventManagerInterface $em)
+    {
+        $this->setEventManager($em);
+        $this->__BaseConstruct($driver, $key);
+    }
+
     /**
      * @param ExtendedCacheItemPoolInterface $driver
      * @return static

tests/lib/Helper/TestHelper.php

@@ -349,8 +349,12 @@ public function accessInaccessibleMember($obj, $prop)
      */
     public function errorHandler(int $errno, string $errstr, string $errfile, int $errline)
     {
-        $errorType = '';
+        // Silenced errors
+        if (!(error_reporting() & $errno)){
+            return;
+        }
 
+        $errorType = '';
         switch ($errno) {
             case E_PARSE:
             case E_ERROR:
@@ -433,6 +437,18 @@ public function runCRUDTests(ExtendedCacheItemPoolInterface $pool, bool $poolCle
         $cacheItem = $pool->getItem($cacheKey);
         $this->printInfoText('Using cache key: ' . $cacheKey);
 
+        /**
+         * Default TTL - 1sec is for dealing with potential script execution delay
+         * @see https://github.com/PHPSocialNetwork/phpfastcache/issues/855
+         */
+        if($cacheItem->getTtl() < $pool->getConfig()->getDefaultTtl() - 1) {
+            $this->assertFail(\sprintf(
+                'The expected TTL of the cache item was ~%ds, got %ds',
+                $pool->getConfig()->getDefaultTtl(),
+                $cacheItem->getTtl()
+            ));
+        }
+
         $cacheItem->set($cacheValue)
             ->expiresAfter(60)
             ->addTags([$cacheTag, $cacheTag2]);